RESOLVED FIXED71862
Towards 8 Bit Strings: Templatize JSC::LiteralParser class by character type 
https://bugs.webkit.org/show_bug.cgi?id=71862
Summary Towards 8 Bit Strings: Templatize JSC::LiteralParser class by character type
Michael Saboff
Reported 2011-11-08 15:08:35 PST
<rdar://problem/10225303>
Attachments
Proposed Patch (37.95 KB, patch)
2011-11-09 13:15 PST, Michael Saboff 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Updated Patch (38.49 KB, patch)
2011-11-09 13:59 PST, Michael Saboff 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2011-11-09 13:15:32 PST
Created attachment 114350 [details] Proposed Patch This patch may not build on non-Mac bots due to exports not being right.
Early Warning System Bot
Comment 2 2011-11-09 13:35:20 PST
Comment on attachment 114350 [details] Proposed Patch Attachment 114350 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10403048
Gyuyoung Kim
Comment 3 2011-11-09 13:48:17 PST
Comment on attachment 114350 [details] Proposed Patch Attachment 114350 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10401056
Michael Saboff
Comment 4 2011-11-09 13:59:58 PST
Created attachment 114363 [details] Updated Patch Speculative fix to qt and elf build failures. Fixed LayoutTests/fast/js/JSON-parse.html due to improper error message generation.
Oliver Hunt
Comment 5 2011-11-09 14:55:28 PST
Comment on attachment 114363 [details] Updated Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114363&action=review r=me > Source/JavaScriptCore/ChangeLog:6 > + Changed LiteralParser to be templatized of character type. s/of/on > Source/JavaScriptCore/ChangeLog:8 > + Moved five enums out of class definition to work around a clang compiler defect. sadness, have you filed a bug on that?
Michael Saboff
Comment 6 2011-11-09 20:54:52 PST
Committed r99812: <http://trac.webkit.org/changeset/99812>
Note You need to log in before you can comment on or make changes to this bug.