Bug 71861 - Basic DFG definitions should be moved out of DFGNode.h
Summary: Basic DFG definitions should be moved out of DFGNode.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 71744
  Show dependency tree / graph
 
Reported: 2011-11-08 15:01 PST by Filip Pizlo
Modified: 2011-11-08 16:12 PST (History)
0 users

See Also:

Attachments
the patch (10.32 KB, patch)
2011-11-08 15:04 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-11-08 15:01:44 PST 
DFGNode.h nominally contains the Node class and things directly related to it.  But right now it also happens to contain a bunch of #define's relating to the DFG's configuration, as well as some common types that the DFG uses everywhere (like BlockIndex and NodeIndex).  These should be moved into a separate file, so that it is possible to refer to those types without having to pull in the definition of Node.
Comment 1 Filip Pizlo 2011-11-08 15:04:32 PST 
Created attachment 114161 [details]
the patch

Checking to see if this makes bots happy.
Comment 2 Filip Pizlo 2011-11-08 16:12:55 PST 
Landed in http://trac.webkit.org/changeset/99627