Bug 71857 - MHTML always use Base64 encoding (instead of QuotedPrintable for text)
Summary: MHTML always use Base64 encoding (instead of QuotedPrintable for text)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jay Civelli
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-08 14:31 PST by Jay Civelli
Modified: 2011-11-09 15:14 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.91 KB, patch)
2011-11-08 14:37 PST, Jay Civelli 		no flags Details | Formatted Diff | Diff
Patch (9.42 KB, patch)
2011-11-09 11:05 PST, Jay Civelli 		no flags Details | Formatted Diff | Diff
Patch (9.42 KB, patch)
2011-11-09 11:08 PST, Jay Civelli 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Civelli 2011-11-08 14:31:36 PST 
When generating a MHTML archive and binary encoding is not used, all resources are encoded in Base64.
Text resources should use QuotedPrintable instead.

This bug was introduced in my previous change that added binary encoding support:
https://bugs.webkit.org/show_bug.cgi?id=63310
Comment 1 Jay Civelli 2011-11-08 14:37:41 PST 
Created attachment 114156 [details]
Patch
Comment 2 Adam Barth 2011-11-08 16:05:38 PST 
Comment on attachment 114156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114156&action=review

Test?

> Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp:181
> +        const char* contentEncoding;

Please initialize scalars.
Comment 3 Jay Civelli 2011-11-09 11:05:42 PST 
Created attachment 114317 [details]
Patch
Comment 4 Jay Civelli 2011-11-09 11:08:52 PST 
Created attachment 114318 [details]
Patch
Comment 5 Jay Civelli 2011-11-09 11:10:10 PST 
(In reply to comment #2)
> (From update of attachment 114156 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114156&action=review
> 
> Test?
Added a Chromium unit-test (as this cannot be tested with a LayoutTest).
 
> > Source/WebCore/loader/archive/mhtml/MHTMLArchive.cpp:181
> > +        const char* contentEncoding;
> 
> Please initialize scalars.
Done.
Comment 6 Adam Barth 2011-11-09 13:34:40 PST 
Comment on attachment 114318 [details]
Patch

Thanks!
Comment 7 WebKit Review Bot 2011-11-09 15:14:16 PST 
Comment on attachment 114318 [details]
Patch

Clearing flags on attachment: 114318

Committed r99766: <http://trac.webkit.org/changeset/99766>
Comment 8 WebKit Review Bot 2011-11-09 15:14:21 PST 
All reviewed patches have been landed.  Closing bug.