Extract ApplicationCacheModel from ApplicationCacheItemsView. This is needed for https://bugs.webkit.org/show_bug.cgi?id=64581 (Web Inspector: ApplicationCache UI is confusing and incorrect.)
Created attachment 114143 [details] Patch
Comment on attachment 114143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114143&action=review > Source/WebCore/WebCore.vcproj/WebCore.vcproj:68574 > RelativePath="..\inspector\front-end\ApplicationCacheItemsView.js" > > > </File> > + <File > + RelativePath="..\inspector\front-end\ApplicationCacheModel.js" > + > > + </File> Just an observation, this file uses tabs instead of spaces.
Comment on attachment 114143 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114143&action=review > Source/WebCore/inspector/front-end/inspector.js:347 > + this.applicationCacheModel = new WebInspector.ApplicationCacheModel(); We should not run appcache initialization code + request appcaches on load and should not make applicationCacheModel instance public. I'd suggest that you keep the private pointer to it in the view + create it lazily.
Created attachment 114249 [details] Patch
(In reply to comment #3) > (From update of attachment 114143 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=114143&action=review > > > Source/WebCore/inspector/front-end/inspector.js:347 > > + this.applicationCacheModel = new WebInspector.ApplicationCacheModel(); > > We should not run appcache initialization code + request appcaches on load and should not make applicationCacheModel instance public. I'd suggest that you keep the private pointer to it in the view + create it lazily. Done. > Just an observation, this file uses tabs instead of spaces. Fixed, thanks for spotting that!
Committed r99689: <http://trac.webkit.org/changeset/99689>