Bug 71850 - Web Inspector: Extract ApplicationCacheModel from ApplicationCacheItemsView.
Summary: Web Inspector: Extract ApplicationCacheModel from ApplicationCacheItemsView.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks: 64581
  Show dependency treegraph
 
Reported: 2011-11-08 13:05 PST by Vsevolod Vlasov
Modified: 2011-11-09 05:02 PST (History)
11 users (show)

See Also:


Attachments
Patch (10.88 KB, patch)
2011-11-08 13:26 PST, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (14.90 KB, patch)
2011-11-09 04:33 PST, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-11-08 13:05:41 PST
Extract ApplicationCacheModel from ApplicationCacheItemsView.

This is needed for https://bugs.webkit.org/show_bug.cgi?id=64581 (Web Inspector: ApplicationCache UI is confusing and incorrect.)
Comment 1 Vsevolod Vlasov 2011-11-08 13:26:19 PST
Created attachment 114143 [details]
Patch
Comment 2 Joseph Pecoraro 2011-11-08 14:03:52 PST
Comment on attachment 114143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114143&action=review

> Source/WebCore/WebCore.vcproj/WebCore.vcproj:68574
>  					RelativePath="..\inspector\front-end\ApplicationCacheItemsView.js"
>  					>
>  				</File>
> +                <File
> +                    RelativePath="..\inspector\front-end\ApplicationCacheModel.js"
> +                    >
> +                </File>

Just an observation, this file uses tabs instead of spaces.
Comment 3 Pavel Feldman 2011-11-08 20:43:23 PST
Comment on attachment 114143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114143&action=review

> Source/WebCore/inspector/front-end/inspector.js:347
> +    this.applicationCacheModel = new WebInspector.ApplicationCacheModel();

We should not run appcache initialization code + request appcaches on load and should not make applicationCacheModel instance public. I'd suggest that you keep the private pointer to it in the view + create it lazily.
Comment 4 Vsevolod Vlasov 2011-11-09 04:33:59 PST
Created attachment 114249 [details]
Patch
Comment 5 Vsevolod Vlasov 2011-11-09 04:36:02 PST
(In reply to comment #3)
> (From update of attachment 114143 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114143&action=review
> 
> > Source/WebCore/inspector/front-end/inspector.js:347
> > +    this.applicationCacheModel = new WebInspector.ApplicationCacheModel();
> 
> We should not run appcache initialization code + request appcaches on load and should not make applicationCacheModel instance public. I'd suggest that you keep the private pointer to it in the view + create it lazily.
Done.

> Just an observation, this file uses tabs instead of spaces.
Fixed, thanks for spotting that!
Comment 6 Vsevolod Vlasov 2011-11-09 05:02:22 PST
Committed r99689: <http://trac.webkit.org/changeset/99689>