WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
71844
Move NSRange / DOMRange functions back to WebFrameInternal
https://bugs.webkit.org/show_bug.cgi?id=71844
Summary
Move NSRange / DOMRange functions back to WebFrameInternal
Joseph Pecoraro
Reported
2011-11-08 11:58:43 PST
The concern was that these methods can easily be used incorrectly because they depend on selection, and exposing them as SPI is a bad idea. So moving them back to Internal. At least we got rid of a couple methods (the ones mentioning Dictionary.app)!
Attachments
[PATCH] Move Functions
(3.24 KB, patch)
2011-11-08 12:00 PST
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1
2011-11-08 12:00:31 PST
Created
attachment 114129
[details]
[PATCH] Move Functions
WebKit Review Bot
Comment 2
2011-11-08 16:13:31 PST
Comment on
attachment 114129
[details]
[PATCH] Move Functions Clearing flags on attachment: 114129 Committed
r99628
: <
http://trac.webkit.org/changeset/99628
>
WebKit Review Bot
Comment 3
2011-11-08 16:13:35 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug