Bug 71842 - Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar.
Summary: Chromium: Add plumbing to enable dragging dev tools via the empty space on th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-08 11:42 PST by asvitkine
Modified: 2011-11-09 07:30 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.10 KB, patch)
2011-11-08 11:44 PST, asvitkine 		no flags Details | Formatted Diff | Diff
Patch (2.46 KB, patch)
2011-11-09 06:51 PST, asvitkine 		pfeldman: review+
pfeldman: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description asvitkine 2011-11-08 11:42:59 PST 
Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar.
Comment 1 asvitkine 2011-11-08 11:44:34 PST 
Created attachment 114125 [details]
Patch
Comment 2 WebKit Review Bot 2011-11-08 11:47:54 PST 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 3 Darin Fisher (:fishd, Google) 2011-11-08 13:21:38 PST 
Comment on attachment 114125 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114125&action=review

> Source/WebKit/chromium/public/WebDevToolsFrontendClient.h:52
> +    virtual void moveWindowBy(float x, float y) { }

nit: had you considered using WebFloatPoint?
Comment 4 asvitkine 2011-11-09 06:51:16 PST 
Created attachment 114265 [details]
Patch
Comment 5 asvitkine 2011-11-09 06:51:45 PST 
As suggested by Darin, here's a version of the patch that uses WebFloatPoint.
Comment 6 asvitkine 2011-11-09 07:22:35 PST 
Can I get a commit-queue+?
Comment 7 Pavel Feldman 2011-11-09 07:30:54 PST 
Committed r99714: <http://trac.webkit.org/changeset/99714>