Bug 71829 – Remove get() defined in CredentialStorageQt.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

CredentialStorage::get() is defined in CredentialStorage.cpp. We shouldn't define it again in the platform-specific CredentialStorage file.

CredentialStorage::get() was added to CredentialStorageQt.cpp in changeset  86172 <http://trac.webkit.org/changeset/86172>. I spoke with Anders Carlsson  today on IRC about this changeset and we came to the conclusion that CredentialStorage::get() shouldn't be defined in CredentialStorageQt.cpp:

[5:41pm] dydx: andersca: I am curious how did you come to the decision to add CredentialStorage::get() in <http://trac.webkit.org/changeset/86172/trunk/Source/WebCore/platform/network/qt/CredentialStorageQt.cpp>
[5:41pm] andersca: dydx: probably to fix the build? 
[5:42pm] dydx: Notice, that CredentialStorage.cpp defines get(): <http://trac.webkit.org/browser/trunk/Source/WebCore/platform/network/CredentialStorage.cpp?rev=86172#L103>
[5:43pm] andersca: dydx: oh, "i thought it would fix the build"? 
[5:44pm] dydx: andersca: Unless you can think of a reason to explicitly have get() be defined in the platform-specific CredentialStorage then I think we should remove CredentialStorage::get() from CredentialStorageQt.cpp
[5:45pm] andersca: dydx: please do

[Daniel Bates]

Created attachment 114109 [details]
Patch

[Daniel Bates]

(In reply to comment #0)
> [5:41pm] dydx: andersca: I am curious how did you come to the decision to add 

We had this conversation at 9:41 am PST. For some reason Colloquy Version 2.3 (4617) on Mac OS 10.7 shows the wrong time in the chat window.

[Andreas Kling]

Comment on attachment 114109 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 114109 [details]
Patch

Clearing flags on attachment: 114109

Committed r99607: <http://trac.webkit.org/changeset/99607>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.