Bug 71826 – Web Inspector: [refactoring] remove a bunch of methods from JavaScriptSourceFrameDelegate

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Andrey Kosyakov]

Those methods that may be implemented with the help of PresentationModel and UISourceCode only don't have to be in JavaScriptsSourceFrameDelegate.

[Andrey Kosyakov]

Created attachment 114101 [details]
Patch

[Pavel Feldman]

Comment on attachment 114101 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114101&action=review

> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:82
> +        this._model.setScriptSource(this._uiSourceCode, newContent, callback);

Nit: We could encapsulate setScriptSource in the uiSourceCode for convenience.

> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:374
> +                this._model.removeBreakpoint(this._uiSourceCode, lineNumber);

A dozen of methods that now accept uiSourceCode as the first argument suggest that they could be declared on that class.

[Pavel Feldman]

Comment on attachment 114101 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114101&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:1183
>              this._scriptsPanel._toggleBreakpointsClicked();

I am fine with declaring _scriptsPanel on the JavaScriptSourceFrame. That way you'll be able to get rid of the delegate entirely. You could either make _setScriptSourceIsBeingEdited public or move the entire JavaScriptSourceFrame into ScriptsPanel class and make everything it needs from ScriptsPanel private.

[Andrey Kosyakov]

Comment on attachment 114101 [details]
Patch

Clearing flags on attachment: 114101

Committed r99717: <http://trac.webkit.org/changeset/99717>

[Andrey Kosyakov]

All reviewed patches have been landed.  Closing bug.