Bug 71823 - Web Inspector: discard injected scripts upon front-end disconnect.
Summary: Web Inspector: discard injected scripts upon front-end disconnect.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-08 08:59 PST by Pavel Feldman
Modified: 2011-11-09 07:05 PST (History)
10 users (show)

See Also:


Attachments
Patch (1.26 KB, patch)
2011-11-08 09:01 PST, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (5.18 KB, patch)
2011-11-09 06:25 PST, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-11-08 08:59:28 PST
Patch to follow.
Comment 1 Pavel Feldman 2011-11-08 09:01:09 PST
Created attachment 114087 [details]
Patch
Comment 2 Yury Semikhatsky 2011-11-09 03:53:19 PST
Comment on attachment 114087 [details]
Patch

Please add a test for this.
Comment 3 Pavel Feldman 2011-11-09 06:25:09 PST
Created attachment 114259 [details]
Patch
Comment 4 Yury Semikhatsky 2011-11-09 06:52:47 PST
Comment on attachment 114259 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114259&action=review

> LayoutTests/http/tests/inspector-enabled/injected-script-discard.html:60
> +            InspectorTest.evaluateInPage(error ? "console.log('Error resolving object')" : "console.log('Resolved object successfully')", callback);

Please add FAILED: prefix to the failing branch so that the test is not rebaselined by mistake.
Comment 5 Pavel Feldman 2011-11-09 07:05:13 PST
Committed r99709: <http://trac.webkit.org/changeset/99709>