Bug 71806 - Web Inspector: crash upon InspectorValue serialization that has 0 value / array entry.
Summary: Web Inspector: crash upon InspectorValue serialization that has 0 value / arr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-08 05:48 PST by Pavel Feldman
Modified: 2011-11-09 03:49 PST (History)
10 users (show)

See Also:

Attachments
Patch (2.79 KB, patch)
2011-11-08 05:49 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
[Patch] Correct patch (2.81 KB, patch)
2011-11-08 05:55 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (5.88 KB, patch)
2011-11-08 08:47 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
[Patch] with grammar fixed. (5.88 KB, patch)
2011-11-08 09:19 PST, Pavel Feldman 		no flags Details | Formatted Diff | Diff
[Patch] with grammar fixed. (5.88 KB, patch)
2011-11-08 09:24 PST, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-11-08 05:48:03 PST 
Patch to follow.
Comment 1 Pavel Feldman 2011-11-08 05:49:45 PST 
Created attachment 114053 [details]
Patch
Comment 2 Pavel Feldman 2011-11-08 05:55:11 PST 
Created attachment 114054 [details]
[Patch] Correct patch
Comment 3 Yury Semikhatsky 2011-11-08 05:58:42 PST 
Comment on attachment 114054 [details]
[Patch] Correct patch

Please add a test for this.
Comment 4 Pavel Feldman 2011-11-08 08:47:53 PST 
Created attachment 114083 [details]
Patch
Comment 5 Alexander Pavlov (apavlov) 2011-11-08 08:50:54 PST 
Comment on attachment 114083 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=114083&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1188
> +        *error = "No node with given id does not belong to the document.";

grammar: "No node with given id belongs to the document."
Also, we don't seem to use trailing dots in the error messages.
Comment 6 Pavel Feldman 2011-11-08 09:19:23 PST 
Created attachment 114091 [details]
[Patch] with grammar fixed.
Comment 7 Pavel Feldman 2011-11-08 09:24:56 PST 
Created attachment 114092 [details]
[Patch] with grammar fixed.
Comment 8 Yury Semikhatsky 2011-11-09 02:28:42 PST 
Comment on attachment 114092 [details]
[Patch] with grammar fixed.

View in context: https://bugs.webkit.org/attachment.cgi?id=114092&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1188
> +        *error = "Node with given id does not belong to the document.";

As Alexander pointed out we don't use trailing dots in other error messages.
Comment 9 Pavel Feldman 2011-11-09 03:49:31 PST 
Committed r99683: <http://trac.webkit.org/changeset/99683>