Bug 71787 - DFG OSR exit code should be generated by a separate compiler, not related to DFG::JITCompiler
Summary: DFG OSR exit code should be generated by a separate compiler, not related to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 71744
  Show dependency treegraph
 
Reported: 2011-11-08 02:38 PST by Filip Pizlo
Modified: 2011-11-08 17:01 PST (History)
1 user (show)

See Also:


Attachments
work in progress (59.95 KB, patch)
2011-11-08 02:40 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
work in progress (125.35 KB, patch)
2011-11-08 03:12 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
work in progress (125.11 KB, patch)
2011-11-08 03:20 PST, Filip Pizlo
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
the patch (127.56 KB, patch)
2011-11-08 14:01 PST, Filip Pizlo
barraclough: review-
Details | Formatted Diff | Diff
the patch (126.77 KB, patch)
2011-11-08 14:15 PST, Filip Pizlo
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-11-08 02:38:02 PST
patch forthcoming
Comment 1 Filip Pizlo 2011-11-08 02:40:00 PST
Created attachment 114020 [details]
work in progress

Still need to do this for 32_64.
Comment 2 Filip Pizlo 2011-11-08 03:12:03 PST
Created attachment 114026 [details]
work in progress

This is not the real patch; I want to see what happens on the bots.
Comment 3 Filip Pizlo 2011-11-08 03:20:53 PST
Created attachment 114029 [details]
work in progress

Did some merging.
Comment 4 Early Warning System Bot 2011-11-08 03:40:14 PST
Comment on attachment 114029 [details]
work in progress

Attachment 114029 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10374047
Comment 5 Gyuyoung Kim 2011-11-08 03:58:20 PST
Comment on attachment 114029 [details]
work in progress

Attachment 114029 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10369063
Comment 6 Filip Pizlo 2011-11-08 14:01:20 PST
Created attachment 114150 [details]
the patch
Comment 7 Gavin Barraclough 2011-11-08 14:05:47 PST
Comment on attachment 114150 [details]
the patch

Please update per http://trac.webkit.org/changeset/99614 (basically replace the calls to jitcode start() with calls to the new executableAddressAtOffset to get a THUMB2 safe address).
Comment 8 Filip Pizlo 2011-11-08 14:15:12 PST
Created attachment 114151 [details]
the patch

Merged with http://trac.webkit.org/changeset/99614
Comment 9 Filip Pizlo 2011-11-08 16:21:29 PST
Landed in http://trac.webkit.org/changeset/99629
Comment 10 Yuqiang Xian 2011-11-08 16:52:27 PST
I guess the Gtk make list should by updated accordingly, i.e. Source/JavaScriptCore/GNUmakefile.list.am
Comment 11 Filip Pizlo 2011-11-08 17:01:45 PST
(In reply to comment #10)
> I guess the Gtk make list should by updated accordingly, i.e. Source/JavaScriptCore/GNUmakefile.list.am

Oops!  Fixed in http://trac.webkit.org/changeset/99637