Bug 71779 – Convert some placeholder-related tests to reftests

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

Convert some placeholder-related tests to reftests

[Kent Tamura]

Created attachment 114008 [details]
Patch

[Ryosuke Niwa]

I don't think we should do this until the bug 60605 is fixed because only Chromium bots run ref tests until the bug 60605 is fixed.

[WebKit Review Bot]

Comment on attachment 114008 [details]
Patch

Attachment 114008 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10374034

New failing tests:
fast/forms/placeholder-position.html

[Kent Tamura]

Created attachment 114019 [details]
Patch 2

Drop placeholder-position.html because Chromium Linux and Windows ignore position of a search cancel button.

[Ryosuke Niwa]

I'll repeat that we shouldn't land this patch until the bug 60605 is fixed.

[Dominic Cooney]

The blocking bug rniwa mentioned is fixed, so someone could review this now?

[Ryosuke Niwa]

Comment on attachment 114019 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=114019&action=review

> LayoutTests/fast/forms/input-placeholder-text-indent-expected.html:10
> +<div style="direction:ltr">

Instead of direction, can we use text-align?

> LayoutTests/fast/forms/search-placeholder-value-changed-expected.html:1
> +<input type="search" placeholder="Test Passed">

Interesting to see how we have a separate test for type="text" (placeholder-set-attribute-expected.html) and type="search" (this).

[Kent Tamura]

Comment on attachment 114019 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=114019&action=review

Thank you for reviewing.

>> LayoutTests/fast/forms/input-placeholder-text-indent-expected.html:10
>> +<div style="direction:ltr">
> 
> Instead of direction, can we use text-align?

No. Even if text-align is right, text-indent adds indentation at the left side.

>> LayoutTests/fast/forms/search-placeholder-value-changed-expected.html:1
>> +<input type="search" placeholder="Test Passed">
> 
> Interesting to see how we have a separate test for type="text" (placeholder-set-attribute-expected.html) and type="search" (this).

http://trac.webkit.org/changeset/37488, which added search-placeholder-value-changed.html, is not specific to type=search. We may update this test for type=text.

[WebKit Review Bot]

Comment on attachment 114019 [details]
Patch 2

Clearing flags on attachment: 114019

Committed r101233: <http://trac.webkit.org/changeset/101233>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.