71773 – Web Inspector: refactor shortcuts and settings screens

RESOLVED FIXED 71773

Web Inspector: refactor shortcuts and settings screens

https://bugs.webkit.org/show_bug.cgi?id=71773

Summary Web Inspector: refactor shortcuts and settings screens

Yury Semikhatsky

Reported 2011-11-07 23:42:53 PST

The way we show and hide shortcuts and settings screens makes it hard adding other HelpScreen descendants to the code as we would have to manually hide all possible screens. Instead we should keep a pointer to the visible instance and hide it automatically when new screen is about to be displayed.

Attachments
Patch (6.10 KB, patch) 2011-11-07 23:44 PST, Yury Semikhatsky	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2011-11-07 23:44:57 PST

Created attachment 114001 [details] Patch

Yury Semikhatsky

Comment 2 2011-11-08 00:56:24 PST

Committed r99533: <http://trac.webkit.org/changeset/99533>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware All

OS All

Product WebKit

Component Web Inspector (Deprecated)

Assignee

Yury Semikhatsky

Reported

2011-11-07 23:42 PST

Modified

2011-11-08 00:56 PST History

CC List

10 users Show

URL

Keywords

Depends on

Blocks