Bug 71764 – Rename CSS document() -> findDocument(), to indicate tree climbing

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Roland Steiner]

Various classes in CSS call CSSStyleSheet's document() function, which climbs the CSS object's tree to locate the document. Rename the function and all calling sites to findDocument() to indicate this overhead.

[Roland Steiner]

Created attachment 113987 [details]
Patch

[Roland Steiner]

Incidentally, Source/WebCore/page/PageSerializer.cpp contains 2 cases where the return value of the document/findDocument() call isn't checked for NULL (see the patch). I'm not familiar enough with the code to know whether this is a potential issue or safe.

[Darin Adler]

(In reply to comment #2)
> Incidentally, Source/WebCore/page/PageSerializer.cpp contains 2 cases where the return value of the document/findDocument() call isn't checked for NULL (see the patch). I'm not familiar enough with the code to know whether this is a potential issue or safe.

You’re right to question that. Hard to tell if there is any real problem.

A separate issue is that some call sites put the document into a Document* and then do some other work and then use it afterward. In some cases a RefPtr<Document> might be needed instead.

[WebKit Review Bot]

Comment on attachment 113987 [details]
Patch

Clearing flags on attachment: 113987

Committed r99595: <http://trac.webkit.org/changeset/99595>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.