Bug 71760 – [chromium] Remove 6 exit time destructors and 6 static initializers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nico Weber]

[chromium] Remove 6 exit time destructors and 6 static initializers

[Nico Weber]

Created attachment 113976 [details]
Patch

[WebKit Review Bot]

Comment on attachment 113976 [details]
Patch

Attachment 113976 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10338847

[Nico Weber]

Created attachment 113980 [details]
Patch

[WebKit Review Bot]

Comment on attachment 113980 [details]
Patch

Attachment 113980 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10333909

[Nico Weber]

Created attachment 113981 [details]
Patch

[Nico Weber]

See http://crbug.com/101600 for the tracking bug.

andersca did this for mac webkit in wk issue 69586.

[Nate Chapin]

Comment on attachment 113981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113981&action=review

r+ with nits.

> Source/WebCore/bindings/v8/ScriptGCEvent.cpp:41
>  #include <wtf/CurrentTime.h>
>  
> +
>  namespace WebCore {

Spurious newline?

> Source/WebCore/bindings/v8/ScriptGCEvent.cpp:45
> -ScriptGCEvent::GCEventListeners ScriptGCEvent::s_eventListeners;
> +typedef Vector<ScriptGCEventListener*> GCEventListeners;
> +static GCEventListeners& sEventListeners()
> +{

No need for the leading 's' in the function name.

> Source/WebCore/bindings/v8/V8Proxy.cpp:774
> +
> +const V8Extensions& V8Proxy::extensions()
> +{
> +    return staticExtensionsList();
>  }

Can we combine this and staticExtensionsList()?

[Nico Weber]

Comment on attachment 113981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113981&action=review

Thanks!

>> Source/WebCore/bindings/v8/ScriptGCEvent.cpp:41
>>  namespace WebCore {
> 
> Spurious newline?

Fixed.

>> Source/WebCore/bindings/v8/ScriptGCEvent.cpp:45
>> +{
> 
> No need for the leading 's' in the function name.

Fixed.

>> Source/WebCore/bindings/v8/V8Proxy.cpp:774
>>  }
> 
> Can we combine this and staticExtensionsList()?

Not easily: This function returns a const reference, but in some places in this function, a non-const reference is needed.

[Nico Weber]

Created attachment 114084 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 114084 [details]
Patch for landing

Clearing flags on attachment: 114084

Committed r99588: <http://trac.webkit.org/changeset/99588>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.