WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
71752
WTF should have an Xcode project
https://bugs.webkit.org/show_bug.cgi?id=71752
Summary
WTF should have an Xcode project
Mark Rowe (bdash)
Reported
2011-11-07 17:13:46 PST
Per the summary.
Attachments
Patch v1
(25.52 KB, patch)
2011-11-07 17:17 PST
,
Mark Rowe (bdash)
abarth
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1
2011-11-07 17:17:24 PST
Created
attachment 113963
[details]
Patch v1 This adds an Xcode project that includes only Stub.cpp and Stub.h. They’re built in to a library at the appropriate path for each configuration (WebKitBuild/{Debug,Release}/libWTF.a and /usr/local/lib/libWTF.a) and headers are installed in to the appropriate location (WebKitBuild/{Debug,Release}/usr/local/include/wtf and /usr/local/include/wtf). I tested building WTF in this project and everything appears to build except for DateMath.cpp (due to
bug 71747
). I have not yet done any work on making JavaScriptCore and other projects use the built products of this new project.
Adam Barth
Comment 2
2011-11-18 23:58:59 PST
Comment on
attachment 113963
[details]
Patch v1 Now that
bug 71747
is fixed, we should probably land this patch. I'll add a ChangeLog. Thanks Mark!
Adam Barth
Comment 3
2011-11-19 00:09:28 PST
Committed
r100850
: <
http://trac.webkit.org/changeset/100850
>
Mark Rowe (bdash)
Comment 4
2011-11-19 01:47:37 PST
It’s not clear to me why you landed my patch without first consulting with me. It wasn’t even marked for review! The patch was intentionally not flagged for review because I have not yet tested whether the built product is suitable for use by other projects. If I had wanted it to be reviewed I’d have set the review flag to ?, and if I had wanted it landed the commit-queue flag would also have been set.
Adam Barth
Comment 5
2011-11-19 10:25:20 PST
Oh, I'm sorry. I misunderstood. I thought we just needed to resolve
bug 71747
. Given that the WTF folder isn't referenced by anything else yet, I don't see any harm in having landed it. Maybe it would make sense to iterate on the xcodeproj now that it's landed?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug