Bug 71749 - IndexedDB: reference cycle between IDBDatabase and IDBTransaction
Summary: IndexedDB: reference cycle between IDBDatabase and IDBTransaction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-07 16:32 PST by Joshua Bell
Modified: 2011-11-08 11:42 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.04 KB, patch)
2011-11-07 16:33 PST, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch (9.89 KB, patch)
2011-11-07 17:06 PST, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch (10.45 KB, patch)
2011-11-08 10:46 PST, Joshua Bell 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2011-11-07 16:32:17 PST 
IndexedDB: reference cycle between IDBDatabase and IDBTransaction
Comment 1 Joshua Bell 2011-11-07 16:33:16 PST 
Created attachment 113953 [details]
Patch
Comment 2 Joshua Bell 2011-11-07 16:36:34 PST 
Comment on attachment 113953 [details]
Patch

Layout test pending.
Comment 3 Joshua Bell 2011-11-07 17:06:00 PST 
Created attachment 113962 [details]
Patch
Comment 4 Joshua Bell 2011-11-07 17:08:22 PST 
Prior to this patch, if you called IDBDatabase.createObjectStore() following a VERSION_CHANGE transaction with an object store name that already existed the call would make it to the back-end before failing, and fail with CONSTRAINT_ERR rather than the expected NOT_ALLOWED_ERR. The updated layout test verifies that the transaction check is now happening on the front-end.
Comment 5 David Grogan 2011-11-07 17:20:01 PST 
LGTM
Comment 6 Joshua Bell 2011-11-08 10:46:49 PST 
Created attachment 114115 [details]
Patch
Comment 7 Joshua Bell 2011-11-08 10:48:50 PST 
Updated the layout test to clarify the new test case based on verbal feedback from dgrogan@. Also fixed the existing tests to actually try removing the object stores as claimed.

tony@ - can you take a look?
Comment 8 WebKit Review Bot 2011-11-08 11:41:57 PST 
Comment on attachment 114115 [details]
Patch

Clearing flags on attachment: 114115

Committed r99599: <http://trac.webkit.org/changeset/99599>
Comment 9 WebKit Review Bot 2011-11-08 11:42:01 PST 
All reviewed patches have been landed.  Closing bug.