Bug 71746 – DFG code base should allow for classes not related to DFG::JITCompiler to use DFG idioms

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

patch forthcoming

[Filip Pizlo]

Created attachment 113951 [details]
the patch

[WebKit Review Bot]

Attachment 113951 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:171:  Missing space inside { }.  [whitespace/braces] [5]
Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:172:  Missing space inside { }.  [whitespace/braces] [5]
Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:173:  Missing space inside { }.  [whitespace/braces] [5]
Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:174:  Missing space inside { }.  [whitespace/braces] [5]
Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:175:  Missing space inside { }.  [whitespace/braces] [5]
Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:224:  The parameter name "flag" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 7 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Created attachment 113952 [details]
the patch

Fixed style.

[Gavin Barraclough]

Comment on attachment 113952 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113952&action=review

> Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:46
> +class AssemblyHelpers: public MacroAssembler {

I think you're missing a space here.

[Filip Pizlo]

(In reply to comment #4)
> (From update of attachment 113952 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113952&action=review
> 
> > Source/JavaScriptCore/dfg/DFGAssemblyHelpers.h:46
> > +class AssemblyHelpers: public MacroAssembler {
> 
> I think you're missing a space here.

i.e. "AssemblyHelpers : public" instead of "AssemblyHelpers: public"?

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/99519

[Filip Pizlo]

<rdar://problem/10410939>