Bug 71736 – Allow gamepad to be enabled at runtime

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Scott Graham]

Add runtime enable for gamepad functionality.

Full patch here https://bugs.webkit.org/show_bug.cgi?id=69451

[Scott Graham]

Created attachment 113933 [details]
Patch

[Scott Graham]

Created attachment 113937 [details]
consistently plural

[Adam Barth]

Comment on attachment 113937 [details]
consistently plural

View in context: https://bugs.webkit.org/attachment.cgi?id=113937&action=review

> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:64
> +bool RuntimeEnabledFeatures::isGamepadsEnabled = false;

"is gamepads" ?  :(

Can we change this to isGamepadEnabled ?

[Scott Graham]

Comment on attachment 113937 [details]
consistently plural

View in context: https://bugs.webkit.org/attachment.cgi?id=113937&action=review

>> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:64
>> +bool RuntimeEnabledFeatures::isGamepadsEnabled = false;
> 
> "is gamepads" ?  :(
> 
> Can we change this to isGamepadEnabled ?

Yes, it's ugly and ungrammatical. :(

gamepadsEnabled() has to be plural because of the binding generation code. So I waffled for a while and went full-plural. Would you like to see just the bool singular? Or both the bool and the setGamepad[s]Enabled function as singular (but not matching the get)?

[Scott Graham]

(In reply to comment #4)
> (From update of attachment 113937 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113937&action=review
> 
> >> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:64
> >> +bool RuntimeEnabledFeatures::isGamepadsEnabled = false;
> > 
> > "is gamepads" ?  :(
> > 
> > Can we change this to isGamepadEnabled ?
> 
> Yes, it's ugly and ungrammatical. :(
> 
> gamepadsEnabled() has to be plural because of the binding generation code. So I waffled for a while and went full-plural. Would you like to see just the bool singular? Or both the bool and the setGamepad[s]Enabled function as singular (but not matching the get)?

Hmm, actually I guess setGamepadsEnabled sounds OK. It just seemed awkward to have that modify a bool that was singular. I'll do that.

[Scott Graham]

Created attachment 113942 [details]
less ungrammatical

[Adam Barth]

Comment on attachment 113942 [details]
less ungrammatical

Ok.  We really should just autogenerate this file.

[WebKit Review Bot]

Comment on attachment 113942 [details]
less ungrammatical

Clearing flags on attachment: 113942

Committed r99500: <http://trac.webkit.org/changeset/99500>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.