Bug 71734 – The Full Keyboard Access preference should be read in the UI process

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Alexey Proskuryakov]

That would let us tighten the sandbox a bit. Also, that's what we do for other global preferences.

<rdar://problem/9237619>

[Alexey Proskuryakov]

Created attachment 113931 [details]
proposed patch

[Darin Adler]

Comment on attachment 113931 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113931&action=review

> Source/WebKit2/WebProcess/WebProcess.h:99
> +    bool fullKeyboardAccessEnabled() { return m_fullKeyboardAccessEnabled; }

Maybe make this const?

> Source/WebKit2/WebProcess/WebProcess.h:146
> +    void fullKeyboardAccessModeChanged(bool mode);

The word “mode” is not a great name for this argument. Maybe “fullKeyboardAcessEabled”?

I’m not sure that xxxChanged is a great name for something that just sets the mode. I think setFullKeyboardAccessEnabled is a better name.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/99483>.

> Maybe make this const?

Done.

> The word “mode” is not a great name for this argument. Maybe “fullKeyboardAcessEabled”?

Done.

> I’m not sure that xxxChanged is a great name for something that just sets the mode. I think setFullKeyboardAccessEnabled is a better name.

I agree that it's slightly better from WebProcess perspective. However, I wanted to keep it consistent with LanguageChanged.