Bug 71730 - ARMv7 MacroAssemblerARMv7.h Build Issue (branchTest8)
Summary: ARMv7 MacroAssemblerARMv7.h Build Issue (branchTest8)
Status: RESOLVED DUPLICATE of bug 71982
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-07 13:44 PST by Joseph Pecoraro
Modified: 2011-11-09 22:32 PST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2011-11-07 13:44:12 PST
Build Error after: <http://trac.webkit.org/changeset/97331>

  In file included from Source/JavaScriptCore/assembler/MacroAssembler.h:32:
  In file included from Source/JavaScriptCore/bytecode/Instruction.h:32:
  In file included from Source/JavaScriptCore/bytecode/CodeBlock.h:37:
  In file included from Source/JavaScriptCore/runtime/JSActivation.h:32:
  In file included from Source/JavaScriptCore/runtime/Arguments.h:27:
  In file included from Source/JavaScriptCore/runtime/Arguments.cpp:26:
  Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1020:34:{1020:34-1020:53}: error: no viable conversion from 'const RegisterID' to 'JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Address' [2]
  Source/JavaScriptCore/assembler/AbstractMacroAssembler.h:70:12: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'const RegisterID' to 'const JSC::AbstractMacroAssembler<JSC::ARMv7Assembler>::Address &' for 1st argument;  [2]
  Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1016:52: note: passing argument to parameter 'address' here [2]
  1 error generated.

The ChangeLog / bug title mentioned that the 8bit version was unsafe for x86:
<http://webkit.org/b/69978> MacroAssemblerX86 8-bit register ops unsafe on CPU(X86)
But the ARM branchTest8 Jump was removed. Is that still safe to put back in for ARM
or does it need to change like x86?
Comment 1 Gavin Barraclough 2011-11-09 22:32:18 PST
This should be fixed by https://bugs.webkit.org/show_bug.cgi?id=71982.

*** This bug has been marked as a duplicate of bug 71982 ***