Bug 71722 – Uninitialized Heap member var

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Andrew Wason]

m_blockFreeingThreadShouldQuit is uninitialized in Source/JavaScriptCore/heap/Heap.cpp

valgrind complains:

==24728== Thread 3:
==24728== Conditional jump or move depends on uninitialised value(s)
==24728==    at 0x6923EF7: JSC::Heap::blockFreeingThreadMain() (Heap.cpp:411)
==24728==    by 0x6923D7B: JSC::Heap::blockFreeingThreadStartFunc(void*) (Heap.cpp:405)
==24728==    by 0x68FF7BC: WTF::threadEntryPoint(void*) (Threading.cpp:67)
==24728==    by 0x68F8618: WTF::ThreadPrivate::run() (ThreadingQt.cpp:67)
==24728==    by 0x91C3FF4: QThreadPrivate::start(void*) (qthread_unix.cpp:331)
==24728==    by 0x96A19C9: start_thread (pthread_create.c:300)
==24728==    by 0xA14C70C: clone (clone.S:112)
==24728== 
==24728== Conditional jump or move depends on uninitialised value(s)
==24728==    at 0x6923CBE: JSC::Heap::waitForRelativeTimeWhileHoldingLock(double) (Heap.cpp:388)
==24728==    by 0x6923D2E: JSC::Heap::waitForRelativeTime(double) (Heap.cpp:400)
==24728==    by 0x6923DAB: JSC::Heap::blockFreeingThreadMain() (Heap.cpp:414)
==24728==    by 0x6923D7B: JSC::Heap::blockFreeingThreadStartFunc(void*) (Heap.cpp:405)
==24728==    by 0x68FF7BC: WTF::threadEntryPoint(void*) (Threading.cpp:67)
==24728==    by 0x68F8618: WTF::ThreadPrivate::run() (ThreadingQt.cpp:67)
==24728==    by 0x91C3FF4: QThreadPrivate::start(void*) (qthread_unix.cpp:331)
==24728==    by 0x96A19C9: start_thread (pthread_create.c:300)
==24728==    by 0xA14C70C: clone (clone.S:112)
==24728== 
==24728== Conditional jump or move depends on uninitialised value(s)
==24728==    at 0x6923DB9: JSC::Heap::blockFreeingThreadMain() (Heap.cpp:415)
==24728==    by 0x6923D7B: JSC::Heap::blockFreeingThreadStartFunc(void*) (Heap.cpp:405)
==24728==    by 0x68FF7BC: WTF::threadEntryPoint(void*) (Threading.cpp:67)
==24728==    by 0x68F8618: WTF::ThreadPrivate::run() (ThreadingQt.cpp:67)
==24728==    by 0x91C3FF4: QThreadPrivate::start(void*) (qthread_unix.cpp:331)
==24728==    by 0x96A19C9: start_thread (pthread_create.c:300)
==24728==    by 0xA14C70C: clone (clone.S:112)

[Andrew Wason]

Created attachment 113915 [details]
initialize m_blockFreeingThreadShouldQuit

[Filip Pizlo]

Comment on attachment 113915 [details]
initialize m_blockFreeingThreadShouldQuit

Ooops!  It's a wonder that this code has "worked" for so long.  Thanks for the fix!  r=me

[Oliver Hunt]

<rdar://problem/10407863>

[WebKit Review Bot]

Comment on attachment 113915 [details]
initialize m_blockFreeingThreadShouldQuit

Clearing flags on attachment: 113915

Committed r99477: <http://trac.webkit.org/changeset/99477>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.