Bug 71681 – [Qt][WK2] Remove TiledDrawingArea and dependencies.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[zalan]

[Qt][WK2] Remove TiledDrawingArea and dependencies.

[zalan]

Created attachment 113860 [details]
Patch

[zalan]

TiledDrawingArea and its dependencies are obsolete. In case that any port needs same/similar functionality, the current class structure needs to be reconsidered. Currently there are lots of duplicated code in TiledDrawingAreaProxy and DrawingAreaImpl. Either Tiled needs to be derived from Impl, or preferably Impl code should be moved up to the base class.

[KwangHyuk]

Hi, zbujtas,

The internal version of WK2-efl's tiled backing store implementation is now based on TiledDrawingArea.

So, I would like to know the next plan after landing of this patch.
Should we have to move from TiledDrawingArea to DrawingArea or LayerTreeHost ?

[zalan]

(In reply to comment #3)
> Hi, zbujtas,
> 
> The internal version of WK2-efl's tiled backing store implementation is now based on TiledDrawingArea.
> 
> So, I would like to know the next plan after landing of this patch.
> Should we have to move from TiledDrawingArea to DrawingArea or LayerTreeHost ?
It's really up to you whether you'd like to keep the original tile approach with a little bit of different class structure (see comment#2). However, that most likely will not work properly in all the cases when both AC and non-AC content are present. Or, as you mentioned, follow the LayerTreeHost(Qt) (TiledBackingStoreRemoteTile) implementation, which properly synchronizes the non-AC with the AC content using tiles. https://bugs.webkit.org/show_bug.cgi?id=69151

[zalan]

(In reply to comment #3)
> Hi, zbujtas,
> 
> The internal version of WK2-efl's tiled backing store implementation is now based on TiledDrawingArea.
> 
> So, I would like to know the next plan after landing of this patch.
> Should we have to move from TiledDrawingArea to DrawingArea or LayerTreeHost ?
Could you let me know, if you are fine with removing these classes? (would be great to know before submitting it for review)

[KwangHyuk]

(In reply to comment #5)
> (In reply to comment #3)
> > Hi, zbujtas,
> > 
> > The internal version of WK2-efl's tiled backing store implementation is now based on TiledDrawingArea.
> > 
> > So, I would like to know the next plan after landing of this patch.
> > Should we have to move from TiledDrawingArea to DrawingArea or LayerTreeHost ?
> Could you let me know, if you are fine with removing these classes? (would be great to know before submitting it for review)

Hi, zbujtas,

I am gathering idea from each related person to know whether anybody has any major issue caused by this patch. :)
I will give you any feedback for this soon.

I sincerely thank you for your notification of this patch in advance.

[KwangHyuk]

LGTM.

We are going to move into LayerTreeHost sooner or later.
However, I prefer it if you remove these files some days later. :)

[zalan]

(In reply to comment #7)
> LGTM.
> 
> We are going to move into LayerTreeHost sooner or later.
> However, I prefer it if you remove these files some days later. :)

sure, just let me know when. i prefer removing it sooner than latter to avoid confusion about its existence.

[KwangHyuk]

(In reply to comment #8)
> (In reply to comment #7)
> > LGTM.
> > 
> > We are going to move into LayerTreeHost sooner or later.
> > However, I prefer it if you remove these files some days later. :)
> 
> sure, just let me know when. i prefer removing it sooner than latter to avoid confusion about its existence.

Thanks for your consideration. :)
Until the end of this month. if it won't hurt your work.

[KwangHyuk]

(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > LGTM.
> > > 
> > > We are going to move into LayerTreeHost sooner or later.
> > > However, I prefer it if you remove these files some days later. :)
> > 
> > sure, just let me know when. i prefer removing it sooner than latter to avoid confusion about its existence.
> 
> Thanks for your consideration. :)
> Until the end of this month. if it won't hurt your work.

I want to see those files until the end of this month if it won't hurt your work.

[zalan]

(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > (In reply to comment #7)
> > > > LGTM.
> > > > 
> > > > We are going to move into LayerTreeHost sooner or later.
> > > > However, I prefer it if you remove these files some days later. :)
> > > 
> > > sure, just let me know when. i prefer removing it sooner than latter to avoid confusion about its existence.
> > 
> > Thanks for your consideration. :)
> > Until the end of this month. if it won't hurt your work.
> 
> I want to see those files until the end of this month if it won't hurt your work.

alright. sounds ok. thanks.

[KwangHyuk]

(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > > (In reply to comment #8)
> > > > (In reply to comment #7)
> > > > > LGTM.
> > > > > 
> > > > > We are going to move into LayerTreeHost sooner or later.
> > > > > However, I prefer it if you remove these files some days later. :)
> > > > 
> > > > sure, just let me know when. i prefer removing it sooner than latter to avoid confusion about its existence.
> > > 
> > > Thanks for your consideration. :)
> > > Until the end of this month. if it won't hurt your work.
> > 
> > I want to see those files until the end of this month if it won't hurt your work.
> 
> alright. sounds ok. thanks.

Thanks too. :)

[Jocelyn Turcotte]

Created attachment 125352 [details]
Patch

Also remove QtSGTileNode and QtSGUpdateQueue.

[Jocelyn Turcotte]

Committed r106800: <http://trac.webkit.org/changeset/106800>