Bug 71667 - CSSValue: Devirtualize cssValueType().
Summary: CSSValue: Devirtualize cssValueType().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks: 71666 71668
  Show dependency tree / graph
 
Reported: 2011-11-07 04:44 PST by Andreas Kling
Modified: 2011-11-07 05:34 PST (History)
2 users (show)

See Also:

Attachments
Patch (8.20 KB, patch)
2011-11-07 04:49 PST, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-11-07 04:44:46 PST 
CSSValue: Devirtualize cssValueType().
Comment 1 Andreas Kling 2011-11-07 04:49:52 PST 
Created attachment 113845 [details]
Patch
Comment 2 Antti Koivisto 2011-11-07 05:10:57 PST 
Comment on attachment 113845 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113845&action=review

r=me

> Source/WebCore/css/CSSValue.h:90
> +private:
> +    unsigned m_type : 3; // Type

Maybe a FIXME here indicating that the memory regression will fix itself soonish.
Comment 3 Antti Koivisto 2011-11-07 05:25:44 PST 
Comment on attachment 113845 [details]
Patch

Also it would be nice if CSSPrimitiveValue had only one field called m_type...
Comment 4 Andreas Kling 2011-11-07 05:34:38 PST 
Committed r99409: <http://trac.webkit.org/changeset/99409>