WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
71667
CSSValue: Devirtualize cssValueType().
https://bugs.webkit.org/show_bug.cgi?id=71667
Summary
CSSValue: Devirtualize cssValueType().
Andreas Kling
Reported
2011-11-07 04:44:46 PST
CSSValue: Devirtualize cssValueType().
Attachments
Patch
(8.20 KB, patch)
2011-11-07 04:49 PST
,
Andreas Kling
koivisto
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2011-11-07 04:49:52 PST
Created
attachment 113845
[details]
Patch
Antti Koivisto
Comment 2
2011-11-07 05:10:57 PST
Comment on
attachment 113845
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=113845&action=review
r=me
> Source/WebCore/css/CSSValue.h:90 > +private: > + unsigned m_type : 3; // Type
Maybe a FIXME here indicating that the memory regression will fix itself soonish.
Antti Koivisto
Comment 3
2011-11-07 05:25:44 PST
Comment on
attachment 113845
[details]
Patch Also it would be nice if CSSPrimitiveValue had only one field called m_type...
Andreas Kling
Comment 4
2011-11-07 05:34:38 PST
Committed
r99409
: <
http://trac.webkit.org/changeset/99409
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug