Bug 71655 - [GTK] fast/frames/flattening/frameset-flattening-simple.html is flaky
Summary: [GTK] fast/frames/flattening/frameset-flattening-simple.html is flaky
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2011-11-07 01:21 PST by Philippe Normand
Modified: 2018-05-10 01:31 PDT (History)
5 users (show)

See Also:


Attachments
proposed patch (1.76 KB, patch)
2011-11-07 01:27 PST, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-11-07 01:21:23 PST
Attaching simple patch.
Comment 1 Philippe Normand 2011-11-07 01:27:20 PST
Created attachment 113833 [details]
proposed patch
Comment 2 Philippe Normand 2011-11-07 09:45:13 PST
Committed r99433: <http://trac.webkit.org/changeset/99433>
Comment 3 Philippe Normand 2011-11-14 10:01:01 PST
It's still flaky :(


--- /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/frames/flattening/frameset-flattening-simple-expected.txt 
+++ /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/frames/flattening/frameset-flattening-simple-actual.txt 
@@ -1,14 +1,14 @@
-layer at (0,0) size 1000x600
-  RenderView at (0,0) size 800x584
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderFrameSet {FRAMESET} at (0,0) size 1000x600
-      RenderFrame {FRAME} at (0,0) size 800x600
-        layer at (0,0) size 800x600
-          RenderView at (0,0) size 800x600
-        layer at (0,0) size 800x600
-          RenderBlock {HTML} at (0,0) size 800x600
-            RenderBody {BODY} at (8,8) size 784x576 [bgcolor=#008000]
+layer at (0,0) size 1000x584
+  RenderView at (0,0) size 784x584
+layer at (0,0) size 784x584
+  RenderBlock {HTML} at (0,0) size 784x584
+    RenderFrameSet {FRAMESET} at (0,0) size 1000x584
+      RenderFrame {FRAME} at (0,0) size 800x584
+        layer at (0,0) size 800x584
+          RenderView at (0,0) size 800x584
+        layer at (0,0) size 800x584
+          RenderBlock {HTML} at (0,0) size 800x584
+            RenderBody {BODY} at (8,8) size 784x560 [bgcolor=#008000]
               RenderBlock {P} at (0,0) size 784x19
                 RenderText {#text} at (0,0) size 445x19
                   text run at (0,0) width 445: "Test for frameset flattening. The flattening only works inside the DRT."
@@ -17,9 +17,9 @@
                   text run at (0,0) width 458: "This frame should be 800px wide and not be scrollable (have scrollbars)."
         layer at (0,100) size 800x1
           RenderBlock (positioned) {DIV} at (0,100) size 800x1
-      RenderFrame {FRAME} at (800,0) size 200x600
-        layer at (0,0) size 200x600
-          RenderView at (0,0) size 200x600
-        layer at (0,0) size 200x600
-          RenderBlock {HTML} at (0,0) size 200x600
-            RenderBody {BODY} at (8,8) size 184x584
+      RenderFrame {FRAME} at (800,0) size 200x584
+        layer at (0,0) size 200x584
+          RenderView at (0,0) size 200x584
+        layer at (0,0) size 200x584
+          RenderBlock {HTML} at (0,0) size 200x584
+            RenderBody {BODY} at (8,8) size 184x568
Comment 4 Philippe Normand 2011-11-15 07:12:05 PST
Marked flaky in http://trac.webkit.org/changeset/100279
Comment 5 Frédéric Wang (:fredw) 2018-02-26 09:17:21 PST
(In reply to Philippe Normand from comment #3)
> It's still flaky :(
> 
> 
> ---
> /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/
> frames/flattening/frameset-flattening-simple-expected.txt 
> +++
> /home/slave/webkitgtk/gtk-linux-64-debug/build/layout-test-results/fast/
> frames/flattening/frameset-flattening-simple-actual.txt 
> -      RenderFrame {FRAME} at (0,0) size 800x600
> +      RenderFrame {FRAME} at (0,0) size 800x584

It seems that the width is always 800px but the height changes, probably because of scrollbars on the main frame. I'm trying to rewrite the test in bug 183129, that would allow to get rid of these scrollbars.
Comment 6 Michael Catanzaro 2018-02-26 10:06:11 PST
Does GTK support frame flattening...?
Comment 7 Frédéric Wang (:fredw) 2018-02-26 10:11:32 PST
(In reply to Michael Catanzaro from comment #6)
> Does GTK support frame flattening...?

Yes, it does.
Comment 8 Frédéric Wang (:fredw) 2018-05-10 01:31:42 PDT
It seems frameset-flattening-simple is no longer flacky on GTK release but there are other similar tests (e.g. from bug 80129 marked as duplicate) that I did not rewrite and are still flacky. Also I wonder why frameset-flattening-simple is failing on debug build only: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&showFlaky=true&tests=frameset-flattening