Bug 71647 – DFG operationCreateThis slow path may get the wrong callee in case of inlining

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

This bug is self-evident in the code, but it's really hard to reproduce - I only saw it when working on a changeset that had bugs in value profiling.  Patch forthcoming.

[Filip Pizlo]

Created attachment 113820 [details]
the patch

[WebKit Review Bot]

Attachment 113820 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGOperations.h:67:  DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Oliver Hunt]

Comment on attachment 113820 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113820&action=review

>> Source/JavaScriptCore/dfg/DFGOperations.h:67
>> +typedef JSCell* DFG_OPERATION (*C_DFGOperation_ECC)(ExecState*, JSCell*, JSCell*);
> 
> DFG_OPERATION is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]

We really should beat the stylebot into not producing these warnings

[Oliver Hunt]

<rdar://problem/10406876>

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/99502