Bug 71646 - Remove unnecessary use of function pointer in FrameSelection::modify()
Summary: Remove unnecessary use of function pointer in FrameSelection::modify()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alice Boxhall
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-06 19:09 PST by Alice Boxhall
Modified: 2011-11-07 15:43 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.53 KB, patch)
2011-11-06 19:10 PST, Alice Boxhall
no flags Details | Formatted Diff | Diff
Patch (1.50 KB, patch)
2011-11-07 14:24 PST, Alice Boxhall
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alice Boxhall 2011-11-06 19:09:28 PST
Remove unnecessary use of function pointer in FrameSelection::modify()
Comment 1 Alice Boxhall 2011-11-06 19:10:45 PST
Created attachment 113818 [details]
Patch
Comment 2 Ryosuke Niwa 2011-11-06 19:41:33 PST
Comment on attachment 113818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113818&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

Please remove this line before commit.
Comment 3 Alice Boxhall 2011-11-07 14:24:30 PST
Created attachment 113930 [details]
Patch
Comment 4 WebKit Review Bot 2011-11-07 14:25:54 PST
Comment on attachment 113930 [details]
Patch

Rejecting attachment 113930 [details] from review queue.

aboxhall@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 5 WebKit Review Bot 2011-11-07 15:43:37 PST
Comment on attachment 113930 [details]
Patch

Clearing flags on attachment: 113930

Committed r99492: <http://trac.webkit.org/changeset/99492>
Comment 6 WebKit Review Bot 2011-11-07 15:43:42 PST
All reviewed patches have been landed.  Closing bug.