Reduce the number of putWithAttributes
Created attachment 113736 [details] Patch
Attachment 113736 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/JSObject.h:110: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 113736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113736&action=review Wait for the EWS bots so you don't break everyone else. > Source/JavaScriptCore/ChangeLog:19 > + Remove four unused JSObject::putWithAttributes overloads and remove make > + one of the remain two overloads not virtual, since no one overloads it. Typo: "remove make one of the remain two" Typo: overloads should be overrides
Committed r99357: <http://trac.webkit.org/changeset/99357>
It appears that this patch caused one jsc regression? http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/34474
(In reply to comment #5) > It appears that this patch caused one jsc regression? > http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/34474 I don't think so. Those test fail from occasionally based no the current time.
(In reply to comment #6) > (In reply to comment #5) > > It appears that this patch caused one jsc regression? > > http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/34474 > > I don't think so. Those test fail from occasionally based no the current time. I see. Thanks for the clarification.