Bug 71585 - Revert platform and scrolling to ints
Summary: Revert platform and scrolling to ints
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 63567
  Show dependency treegraph
 
Reported: 2011-11-04 13:40 PDT by Emil A Eklund
Modified: 2011-11-07 18:11 PST (History)
6 users (show)

See Also:


Attachments
Patch (76.74 KB, patch)
2011-11-04 15:33 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff
Patch for landing (78.07 KB, patch)
2011-11-07 16:37 PST, Emil A Eklund
no flags Details | Formatted Diff | Diff
Patch for landing (78.29 KB, patch)
2011-11-07 17:31 PST, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2011-11-04 13:40:16 PDT
We are currently incorrectly using LayoutUnits and related types in a couple of places in the platform and scrolling code. These should be reverted back to ints.
Comment 1 Emil A Eklund 2011-11-04 15:33:13 PDT
Created attachment 113719 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-11-04 15:44:53 PDT
Comment on attachment 113719 [details]
Patch

OK.
Comment 3 WebKit Review Bot 2011-11-04 15:55:23 PDT
Comment on attachment 113719 [details]
Patch

Attachment 113719 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10337137
Comment 4 Emil A Eklund 2011-11-07 16:37:05 PST
Created attachment 113956 [details]
Patch for landing
Comment 5 WebKit Review Bot 2011-11-07 17:14:46 PST
Comment on attachment 113956 [details]
Patch for landing

Rejecting attachment 113956 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/10331863
Comment 6 Adam Barth 2011-11-07 17:17:39 PST
Comment on attachment 113956 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=113956&action=review

> Source/WebKit/chromium/ChangeLog:3
> +        Need a short description and bug URL (OOPS!)

The following ChangeLog files contain OOPS:

        trunk/Source/WebKit/chromium/ChangeLog

    Please don't ever say "OOPS" in a ChangeLog file.
Comment 7 Emil A Eklund 2011-11-07 17:23:49 PST
Ah, missed one. Thanks for pointing it out Adam.
Comment 8 Emil A Eklund 2011-11-07 17:31:06 PST
Created attachment 113966 [details]
Patch for landing
Comment 9 WebKit Review Bot 2011-11-07 18:11:23 PST
Comment on attachment 113966 [details]
Patch for landing

Clearing flags on attachment: 113966

Committed r99511: <http://trac.webkit.org/changeset/99511>
Comment 10 WebKit Review Bot 2011-11-07 18:11:28 PST
All reviewed patches have been landed.  Closing bug.