Bug 71561 - [Chromium] Crash in WebAccessibilityObject::lineBreaks
Summary: [Chromium] Crash in WebAccessibilityObject::lineBreaks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dominic Mazzoni
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-04 08:15 PDT by Dominic Mazzoni
Modified: 2011-11-09 15:28 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.31 KB, patch)
2011-11-04 09:30 PDT, Dominic Mazzoni 		no flags Details | Formatted Diff | Diff
Patch (5.67 KB, patch)
2011-11-04 15:43 PDT, Dominic Mazzoni 		no flags Details | Formatted Diff | Diff
Patch for landing (5.67 KB, patch)
2011-11-09 13:59 PST, Dominic Mazzoni 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Mazzoni 2011-11-04 08:15:59 PDT 
The problem is that WebCore::AccessibilityObject::lineForPosition returns -1, but WebAccessibilityObject::lineBreaks is assuming it's a number >= 0. The crash happens when it tries to allocate a WebVector of size -1.
Comment 1 Dominic Mazzoni 2011-11-04 09:30:09 PDT 
Created attachment 113666 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-11-04 13:30:11 PDT 
Comment on attachment 113666 [details]
Patch

Can haz layout test?
Comment 3 Dominic Mazzoni 2011-11-04 15:43:55 PDT 
Created attachment 113721 [details]
Patch
Comment 4 Dimitri Glazkov (Google) 2011-11-09 12:23:02 PST 
Comment on attachment 113721 [details]
Patch

pretty.
Comment 5 Dominic Mazzoni 2011-11-09 13:59:52 PST 
Created attachment 114362 [details]
Patch for landing
Comment 6 WebKit Review Bot 2011-11-09 15:28:32 PST 
Comment on attachment 114362 [details]
Patch for landing

Clearing flags on attachment: 114362

Committed r99770: <http://trac.webkit.org/changeset/99770>
Comment 7 WebKit Review Bot 2011-11-09 15:28:37 PST 
All reviewed patches have been landed.  Closing bug.