Bug 71553 – [EFL] Need to replace api's object parameter with proper name.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[KwangHyuk]

Some parameter's name on ewk doesn't seem well defined enough.

For example,

> static void _ewk_view_tiled_smart_add(Evas_Object* ewkTile)
> Ewk_Tile_Unused_Cache* ewk_view_tiled_unused_cache_get(const Evas_Object* ewkTile)
ewkTile must be repalced with ewkView.

> void ewk_tiled_backing_store_updates_process(Evas_Object* ewkTile)
> Eina_Bool ewk_tiled_backing_store_update(Evas_Object* ewkTile, const Eina_Rectangle* update)
ewkTile must be replaced with backingStore.

Gyuyoung or I will fix them if there is no objection.

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #0)
> Some parameter's name on ewk doesn't seem well defined enough.
> 
> For example,
> 
> > static void _ewk_view_tiled_smart_add(Evas_Object* ewkTile)
> > Ewk_Tile_Unused_Cache* ewk_view_tiled_unused_cache_get(const Evas_Object* ewkTile)
> ewkTile must be repalced with ewkView.
These are only examples and you're going to replace it in other functions such as ewk_view_tiled_unused_cache_set as well, right? How about the ewk_view_single functions?

> > void ewk_tiled_backing_store_updates_process(Evas_Object* ewkTile)
> > Eina_Bool ewk_tiled_backing_store_update(Evas_Object* ewkTile, const Eina_Rectangle* update)
> ewkTile must be replaced with backingStore.

OK.

[Gyuyoung Kim]

Created attachment 113814 [details]
Patch

[Gyuyoung Kim]

I fix wrong parameter names with proper's name. 

 - ewkTile -> ewkView in ewk_view_tiled.cpp
 - ewkSingle -> ewkView in ewk_view_single.cpp
 - ewkTile -> ewkBackingStore in ewk_tiled_backing_store.cpp
 - Change w, h, ctxt with width, height, context.
 - and so on.

[KwangHyuk]

LGTM.

[Filip Pizlo]

Comment on attachment 113814 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 113814 [details]
Patch

Clearing flags on attachment: 113814

Committed r99518: <http://trac.webkit.org/changeset/99518>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.