WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
71549
new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
https://bugs.webkit.org/show_bug.cgi?id=71549
Summary
new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
Eric Seidel (no email)
Reported
2011-11-04 02:22:50 PDT
new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to Per:
https://bugs.webkit.org/show_bug.cgi?id=71494#c7
This is a regression from instantiating a Host() object in new-run-webkit-tests. The best fix is probably to split IRC off of the core Host object.
Attachments
Patch
(11.57 KB, patch)
2011-11-04 14:28 PDT
,
Eric Seidel (no email)
abarth
: review+
abarth
: commit-queue+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2011-11-04 14:28:01 PDT
Created
attachment 113715
[details]
Patch
Adam Barth
Comment 2
2011-11-04 14:30:00 PDT
Comment on
attachment 113715
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=113715&action=review
> Tools/Scripts/webkitpy/tool/main.py:65 > + def port(self):
Can we rename this to deprecated_port() ? Probably best in a follow-up patch.
Eric Seidel (no email)
Comment 3
2011-11-04 15:09:15 PDT
Committed
r99326
: <
http://trac.webkit.org/changeset/99326
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug