Bug 71543 - [Chromium] Layout Test media/media-element-play-after-eos.html is flaky
Summary: [Chromium] Layout Test media/media-element-play-after-eos.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ami Fischman
URL: http://test-results.appspot.com/dashb...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-04 00:42 PDT by Yuta Kitamura
Modified: 2011-12-21 22:21 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.77 KB, patch)
2011-12-16 11:18 PST, Ami Fischman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-11-04 00:42:50 PDT
The following layout test sometimes times out on all platforms.

media/media-element-play-after-eos.html

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmedia-element-play-after-eos.html

Probable cause:
Not sure. First appearance seems to be <http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Win%20(dbg)(2)/builds/5990>, which spans the following revision range:
- http://trac.webkit.org/log/?verbose=on&rev=98023&stop_rev=97991
- http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog.html?url=/trunk/src&mode=html&range=106588:106512

I couldn't find any suspicious revision from this range.
Comment 1 Ami Fischman 2011-12-16 11:18:38 PST
Created attachment 119638 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-12-21 14:04:40 PST
Comment on attachment 119638 [details]
Patch

Amen!
Comment 3 Eric Seidel (no email) 2011-12-21 14:04:59 PST
Eric Carlson often likes to see media changes go by. :)
Comment 4 WebKit Review Bot 2011-12-21 15:19:05 PST
Comment on attachment 119638 [details]
Patch

Rejecting attachment 119638 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
webkit-commit-queue/Source/WebKit/chromium/webkit --revision 115012 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
47>At revision 115012.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/11000137
Comment 5 Ami Fischman 2011-12-21 15:40:02 PST
Trying again...
Comment 6 WebKit Review Bot 2011-12-21 15:44:46 PST
Comment on attachment 119638 [details]
Patch

Rejecting attachment 119638 [details] from commit-queue.

fischman@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 7 Eric Seidel (no email) 2011-12-21 15:52:38 PST
Seems we should catch these "cant reach svn.webkit.org" errors and not fail thte patch. :(
Comment 8 WebKit Review Bot 2011-12-21 22:20:59 PST
Comment on attachment 119638 [details]
Patch

Clearing flags on attachment: 119638

Committed r103495: <http://trac.webkit.org/changeset/103495>
Comment 9 WebKit Review Bot 2011-12-21 22:21:03 PST
All reviewed patches have been landed.  Closing bug.