Bug 71534 - [V8] On neutering TypedArrayViews, V8 should be notified to drain code generation cache
Summary: [V8] On neutering TypedArrayViews, V8 should be notified to drain code genera...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dmitry Lomov
URL:
Keywords:
Depends on:
Blocks: 66578
  Show dependency treegraph
 
Reported: 2011-11-03 19:58 PDT by Dmitry Lomov
Modified: 2011-11-07 16:59 PST (History)
4 users (show)

See Also:


Attachments
Fix (8.53 KB, patch)
2011-11-07 15:57 PST, Dmitry Lomov
no flags Details | Formatted Diff | Diff
Style nit (8.35 KB, patch)
2011-11-07 15:59 PST, Dmitry Lomov
levin: review+
levin: commit-queue-
Details | Formatted Diff | Diff
Removed OOPS (8.29 KB, patch)
2011-11-07 16:20 PST, Dmitry Lomov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Lomov 2011-11-03 19:58:38 PDT
V8 optimizes accesses to typed array views. When array views are neutered, relevant code should be regerenerated
Comment 1 Dmitry Lomov 2011-11-07 15:57:42 PST
Created attachment 113945 [details]
Fix
Comment 2 Dmitry Lomov 2011-11-07 15:59:35 PST
Created attachment 113947 [details]
Style nit
Comment 3 David Levin 2011-11-07 16:15:43 PST
Adam, do we need to change the test idl to verify this idl change?
Comment 4 David Levin 2011-11-07 16:15:58 PST
(In reply to comment #3)
> Adam, do we need to change the test idl to verify this idl change?

I meant generator change.
Comment 5 Adam Barth 2011-11-07 16:17:05 PST
You can if you like, but it's not required.
Comment 6 David Levin 2011-11-07 16:18:22 PST
Comment on attachment 113947 [details]
Style nit

Seems fine. I'm not sure that a change to the test idl bindings would add any value so I'll leave that to your discretion.
Comment 7 David Levin 2011-11-07 16:18:54 PST
Comment on attachment 113947 [details]
Style nit

Need to remove first oops.
Comment 8 Dmitry Lomov 2011-11-07 16:20:33 PST
Created attachment 113949 [details]
Removed OOPS
Comment 9 WebKit Review Bot 2011-11-07 16:59:49 PST
Comment on attachment 113949 [details]
Removed OOPS

Clearing flags on attachment: 113949

Committed r99507: <http://trac.webkit.org/changeset/99507>
Comment 10 WebKit Review Bot 2011-11-07 16:59:54 PST
All reviewed patches have been landed.  Closing bug.