Bug 71530 - [Qt] Adding methods setGeometry and setFont to QWebSelectMethod class.
Summary: [Qt] Adding methods setGeometry and setFont to QWebSelectMethod class.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Luiz Agostini
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-11-03 18:03 PDT by Luiz Agostini
Modified: 2011-11-11 13:29 PST (History)
2 users (show)

See Also:

Attachments
patch (3.67 KB, patch)
2011-11-03 18:31 PDT, Luiz Agostini 		hausmann: review+
Details | Formatted Diff | Diff
patch (5.68 KB, patch)
2011-11-08 16:03 PST, Luiz Agostini 		no flags Details | Formatted Diff | Diff
patch (5.68 KB, patch)
2011-11-10 11:35 PST, Luiz Agostini 		luiz: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luiz Agostini 2011-11-03 18:03:50 PDT 
Adding methods setGeometry and setFont to QWebSelectMethod class.
Comment 1 Luiz Agostini 2011-11-03 18:31:40 PDT 
Created attachment 113603 [details]
patch
Comment 2 Simon Hausmann 2011-11-03 23:08:59 PDT 
Comment on attachment 113603 [details]
patch

r=me, but can you adapt the example in WebKit/qt/examples/platformplugin before landing? (fix the duplicated header and the example implementation to compile with the new virtual methods)
Comment 3 Luiz Agostini 2011-11-08 16:03:11 PST 
Created attachment 114167 [details]
patch
Comment 4 WebKit Review Bot 2011-11-08 16:05:01 PST 
Attachment 114167 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/Api/qwebkitplatformplugin..." exit_code: 1

Source/WebKit/qt/examples/platformplugin/WebPlugin.h:75:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebKit/qt/examples/platformplugin/WebPlugin.h:76:  Missing space inside { }.  [whitespace/braces] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Luiz Agostini 2011-11-10 11:35:34 PST 
Created attachment 114532 [details]
patch
Comment 6 Luiz Agostini 2011-11-11 13:29:20 PST 
landed r99903