RESOLVED FIXED 71530
[Qt] Adding methods setGeometry and setFont to QWebSelectMethod class. 
https://bugs.webkit.org/show_bug.cgi?id=71530
Summary [Qt] Adding methods setGeometry and setFont to QWebSelectMethod class.
Luiz Agostini
Reported 2011-11-03 18:03:50 PDT
Adding methods setGeometry and setFont to QWebSelectMethod class.
Attachments
patch (3.67 KB, patch)
2011-11-03 18:31 PDT, Luiz Agostini 		hausmann: review+
DetailsFormatted DiffDiff
patch (5.68 KB, patch)
2011-11-08 16:03 PST, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
patch (5.68 KB, patch)
2011-11-10 11:35 PST, Luiz Agostini 		luiz: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2011-11-03 18:31:40 PDT
Created attachment 113603 [details] patch
Simon Hausmann
Comment 2 2011-11-03 23:08:59 PDT
Comment on attachment 113603 [details] patch r=me, but can you adapt the example in WebKit/qt/examples/platformplugin before landing? (fix the duplicated header and the example implementation to compile with the new virtual methods)
Luiz Agostini
Comment 3 2011-11-08 16:03:11 PST
Created attachment 114167 [details] patch
WebKit Review Bot
Comment 4 2011-11-08 16:05:01 PST
Attachment 114167 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/qt/Api/qwebkitplatformplugin..." exit_code: 1 Source/WebKit/qt/examples/platformplugin/WebPlugin.h:75: Missing space inside { }. [whitespace/braces] [5] Source/WebKit/qt/examples/platformplugin/WebPlugin.h:76: Missing space inside { }. [whitespace/braces] [5] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Luiz Agostini
Comment 5 2011-11-10 11:35:34 PST
Created attachment 114532 [details] patch
Luiz Agostini
Comment 6 2011-11-11 13:29:20 PST
landed r99903
Note You need to log in before you can comment on or make changes to this bug.