Bug 71529 - [chromium] Write unit tests for compositor-thread zooming
: [chromium] Write unit tests for compositor-thread zooming
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-11-03 17:58 PST by
Modified: 2012-01-20 19:19 PST (History)


Attachments
Patch (11.51 KB, patch)
2012-01-20 15:38 PST, Alexandre Elias
no flags Review Patch | Details | Formatted Diff | Diff
Patch (11.50 KB, patch)
2012-01-20 16:05 PST, Alexandre Elias
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-11-03 17:58:37 PST
[chromium] Write unit tests for compositor-thread zooming
------- Comment #1 From 2012-01-20 15:38:42 PST -------
Created an attachment (id=123396) [details]
Patch
------- Comment #2 From 2012-01-20 15:40:15 PST -------
Finally got around to writing some tests for this.  Please take a look.
------- Comment #3 From 2012-01-20 16:01:36 PST -------
(From update of attachment 123396 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=123396&action=review

R=me

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:181
> +    const float minPageScale = 0.5f, maxPageScale = 4;

nit: webkit style is to define these sorts of literals as "0.5" without the trailing "f"

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:219
> +        float pageScaleDelta = 0.1f;

same here: WK style prefers "0.1"

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:240
> +    const float minPageScale = 0.5f, maxPageScale = 4;

ditto
------- Comment #4 From 2012-01-20 16:05:51 PST -------
Created an attachment (id=123400) [details]
Patch
------- Comment #5 From 2012-01-20 16:24:36 PST -------
(From update of attachment 123400 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=123400&action=review

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:275
> +        expectContains(*scrollInfo.get(), scrollLayer->id(), IntSize(-50, -50));

FYI for the future, with WebKit smart pointers doing *ptr is the same as *ptr.get()
------- Comment #6 From 2012-01-20 19:19:25 PST -------
(From update of attachment 123400 [details])
Clearing flags on attachment: 123400

Committed r105566: <http://trac.webkit.org/changeset/105566>
------- Comment #7 From 2012-01-20 19:19:30 PST -------
All reviewed patches have been landed.  Closing bug.