Bug 71529 – [chromium] Write unit tests for compositor-thread zooming

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alexandre Elias]

[chromium] Write unit tests for compositor-thread zooming

[Alexandre Elias]

Created attachment 123396 [details]
Patch

[Alexandre Elias]

Finally got around to writing some tests for this.  Please take a look.

[James Robinson]

Comment on attachment 123396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123396&action=review

R=me

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:181
> +    const float minPageScale = 0.5f, maxPageScale = 4;

nit: webkit style is to define these sorts of literals as "0.5" without the trailing "f"

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:219
> +        float pageScaleDelta = 0.1f;

same here: WK style prefers "0.1"

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:240
> +    const float minPageScale = 0.5f, maxPageScale = 4;

ditto

[Alexandre Elias]

Created attachment 123400 [details]
Patch

[James Robinson]

Comment on attachment 123400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123400&action=review

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:275
> +        expectContains(*scrollInfo.get(), scrollLayer->id(), IntSize(-50, -50));

FYI for the future, with WebKit smart pointers doing *ptr is the same as *ptr.get()

[WebKit Review Bot]

Comment on attachment 123400 [details]
Patch

Clearing flags on attachment: 123400

Committed r105566: <http://trac.webkit.org/changeset/105566>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.