WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
71474
[GTK] Show url of history items in a status bar in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71474
Summary
[GTK] Show url of history items in a status bar in MiniBrowser
Carlos Garcia Campos
Reported
2011-11-03 07:37:31 PDT
We used a GtkStatusbar for that, but I think we can use a GtkOverlay instead.
Attachments
Patch
(4.56 KB, patch)
2011-11-03 07:44 PDT
,
Carlos Garcia Campos
mrobinson
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2011-11-03 07:44:12 PDT
Created
attachment 113491
[details]
Patch
Martin Robinson
Comment 2
2011-11-03 09:17:37 PDT
Comment on
attachment 113491
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=113491&action=review
Okay.
> Tools/MiniBrowser/gtk/BrowserWindow.c:43 > + GtkWidget *statusLabel;
statusLabel -> statusOverlay ?
> Tools/MiniBrowser/gtk/BrowserWindow.c:58 > +#if GTK_CHECK_VERSION(3, 2, 0)
So it begins. :(
> Tools/MiniBrowser/gtk/BrowserWindow.c:66 > + browserWindowSetStatusText(window, 0);
0 -> NULL
> Tools/MiniBrowser/gtk/BrowserWindow.c:106 > + browserWindowSetStatusText(window, action ? gtk_action_get_name(action) : 0);
0 -> NULL
> Tools/MiniBrowser/gtk/BrowserWindow.c:268 > + window->statusLabel = gtk_label_new(0);
0 -> NULL
Carlos Garcia Campos
Comment 3
2011-11-03 10:07:09 PDT
Committed
r99207
: <
http://trac.webkit.org/changeset/99207
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug