Bug 71469 – [Qt] Unable to start MiniBrowser after run-webkit-tests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Hausmann]

[Qt] Unable to start MiniBrowser after run-webkit-tests

[Simon Hausmann]

Running produced the following error:


Traceback (most recent call last):
  File "/home/shausman/src/webkit/trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 436, in <module>
    sys.exit(main())
  File "/home/shausman/src/webkit/trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 431, in main
    return run(port, options, args)
  File "/home/shausman/src/webkit/trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 107, in run
    num_unexpected_results = manager.run(result_summary)
  File "/home/shausman/src/webkit/trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 928, in run
    self._show_results_html_file(result_summary)
  File "/home/shausman/src/webkit/trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 1377, in _show_results_html_file
    self._port.show_results_html_file(results_filename)
  File "/home/shausman/src/webkit/trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py", line 155, in show_results_html_file
    self._run_script("run-launcher", run_launcher_args)
  File "/home/shausman/src/webkit/trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py", line 110, in _run_script
    return self._executive.run_command(run_script_command, cwd=self._config.webkit_base_dir(), decode_output=decode_output)
  File "/home/shausman/src/webkit/trunk/Tools/Scripts/webkitpy/common/system/executive.py", line 441, in run_command
    (error_handler or self.default_error_handler)(script_error)
  File "/home/shausman/src/webkit/trunk/Tools/Scripts/webkitpy/common/system/executive.py", line 358, in default_error_handler
    raise error
webkitpy.common.system.executive.ScriptError: Failed to run "[u'Tools/Scripts/run-launcher', u'--release', u'--qt', u'-2', u'file:///home/shausman/src/webkit/..." exit_code: 1 cwd: /home/shausman/src/webkit/trunk

It appears that's because MiniBrowser doesn't like the -2 passed to it.

[Simon Hausmann]

Created attachment 113480 [details]
[Qt] Unable to start MiniBrowser after run-webkit-tests

[Chang Shu]

Comment on attachment 113480 [details]
[Qt] Unable to start MiniBrowser after run-webkit-tests

It seems we are going back and forth with some changes here. The '-2' line is added recently to fix the same issue. Looks like something else has changed.
http://trac.webkit.org/changeset?new=97158%40trunk%2FTools%2FScripts%2Fwebkitpy%2Flayout_tests%2Fport%2Fqt.py&old=91866%40trunk%2FTools%2FScripts%2Fwebkitpy%2Flayout_tests%2Fport%2Fqt.py

[Simon Hausmann]

Once thing that _has_ changed is that MiniBrowser doesn't accept random options anymore. (it used to ignore anymore

[Simon Hausmann]

Created attachment 113484 [details]
[Qt] Unable to start MiniBrowser after run-webkit-tests

[Simon Hausmann]

Created attachment 113485 [details]
[Qt] Unable to start MiniBrowser after run-webkit-tests

[Csaba Osztrogonác]

Comment on attachment 113485 [details]
[Qt] Unable to start MiniBrowser after run-webkit-tests

LGTM, r=me

[WebKit Review Bot]

Comment on attachment 113485 [details]
[Qt] Unable to start MiniBrowser after run-webkit-tests

Rejecting attachment 113485 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 420, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/10259572

[Simon Hausmann]

Comment on attachment 113485 [details]
[Qt] Unable to start MiniBrowser after run-webkit-tests

Clearing flags on attachment: 113485

Committed r99193: <http://trac.webkit.org/changeset/99193>

[Simon Hausmann]

All reviewed patches have been landed.  Closing bug.