RESOLVED FIXED71435
Move NSRange / DOMRange conversion functions to WebFramePrivate 
https://bugs.webkit.org/show_bug.cgi?id=71435
Summary Move NSRange / DOMRange conversion functions to WebFramePrivate
Joseph Pecoraro
Reported 2011-11-02 19:09:20 PDT
Move the following from WebFrame (WebInternal) to WebFrame (WebPrivate): - (DOMRange *)_convertNSRangeToDOMRange:(NSRange)nsrange - (NSRange)_convertDOMRangeToNSRange:(DOMRange *)range Remove the old version that were left around for Leopard but are no longer used.
Attachments
[PATCH] Move Functions to WebFramePrivate (3.97 KB, patch)
2011-11-02 19:15 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2011-11-02 19:15:55 PDT
Created attachment 113421 [details] [PATCH] Move Functions to WebFramePrivate
WebKit Review Bot
Comment 2 2011-11-02 22:28:32 PDT
Comment on attachment 113421 [details] [PATCH] Move Functions to WebFramePrivate Clearing flags on attachment: 113421 Committed r99139: <http://trac.webkit.org/changeset/99139>
WebKit Review Bot
Comment 3 2011-11-02 22:28:36 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4 2011-11-03 09:47:11 PDT
Comment on attachment 113421 [details] [PATCH] Move Functions to WebFramePrivate View in context: https://bugs.webkit.org/attachment.cgi?id=113421&action=review > Source/WebKit/mac/WebView/WebFrame.mm:-695 > -- (DOMRange *)convertNSRangeToDOMRange:(NSRange)nsrange > -{ > - // This method exists to maintain compatibility with Leopard's Dictionary.app. <rdar://problem/6002160> > - return [self _convertNSRangeToDOMRange:nsrange]; > -} If removing this, we should also remove the -[WebHTMLView _bridge] method.
Note You need to log in before you can comment on or make changes to this bug.