Bug 71434 - FunctionPtr should accept FASTCALL functions on X86
Summary: FunctionPtr should accept FASTCALL functions on X86
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-02 19:05 PDT by Yuqiang Xian
Modified: 2011-11-02 20:13 PDT (History)
3 users (show)

See Also:


Attachments
proposed patch (2.90 KB, patch)
2011-11-02 19:09 PDT, Yuqiang Xian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuqiang Xian 2011-11-02 19:05:17 PDT
On X86 we sometimes use FASTCALL convention functions, for example the cti functions, and we may need the pointers to such functions, e.g., in current DFG register file check and arity check, though long term we may avoid such usage of cti calls in DFG.
Comment 1 Yuqiang Xian 2011-11-02 19:09:23 PDT
Created attachment 113420 [details]
proposed patch
Comment 2 WebKit Review Bot 2011-11-02 20:13:43 PDT
Comment on attachment 113420 [details]
proposed patch

Clearing flags on attachment: 113420

Committed r99133: <http://trac.webkit.org/changeset/99133>
Comment 3 WebKit Review Bot 2011-11-02 20:13:47 PDT
All reviewed patches have been landed.  Closing bug.