Bug 71420 – Stop abusing RenderTableSection::needsRecalcCells logic

• Status: RESOLVED
• Resolution: FIXED
• Component: Tables

[Julien Chaffraix]

The current code badly misuses the needsRecalcCells logic.

Cells recalculation is an expensive operation that requires throwing off our internal representation and some layout information. It is meant for changes in the section's structure that mandates such a safe approach. Some part of the code forces this path for logical height changes, which does not make sense at all.

Let's remove those bad usage.

[Julien Chaffraix]

Created attachment 113406 [details]
Provide some alternative to needsRecalcCells when it is not appropriate to call it.

[WebKit Review Bot]

Comment on attachment 113406 [details]
Provide some alternative to needsRecalcCells when it is not appropriate to call it.

Attachment 113406 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10128777

New failing tests:
fast/repaint/table-extra-bottom-grow.html

[Julien Chaffraix]

Created attachment 113416 [details]
Added proper rebaseline for the progressing test.

[Julien Chaffraix]

Created attachment 113503 [details]
Fixed test_expectations.txt that were wrong.

[Julien Chaffraix]

Created attachment 113512 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 113512 [details]
Patch for landing

Clearing flags on attachment: 113512

Committed r99212: <http://trac.webkit.org/changeset/99212>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #6)
> (From update of attachment 113512 [details])
> Clearing flags on attachment: 113512
> 
> Committed r99212: <http://trac.webkit.org/changeset/99212>

FYI: It broke layout testing on qt-mac platform, because fast/repaint/table-extra-bottom-grow.html is in qt-mac/Skipped file too and NRWT doesn't like duplicated entries.

2011-11-03 10:38:35,835 16718 test_expectations.py:791 ERROR FAILURES FOR <mac, x86, release, cpu> in LayoutTests/platform/qt/test_expectations.txt
2011-11-03 10:38:35,836 16718 test_expectations.py:794 ERROR Line:5530 Duplicate or ambiguous expectation. fast/repaint/table-extra-bottom-grow.html

I removed this entry from test_expectations.txt.

[Julien Chaffraix]

(In reply to comment #8)
> (In reply to comment #6)
> > (From update of attachment 113512 [details] [details])
> > Clearing flags on attachment: 113512
> > 
> > Committed r99212: <http://trac.webkit.org/changeset/99212>
> 
> FYI: It broke layout testing on qt-mac platform, because fast/repaint/table-extra-bottom-grow.html is in qt-mac/Skipped file too and NRWT doesn't like duplicated entries.
> 
> 2011-11-03 10:38:35,835 16718 test_expectations.py:791 ERROR FAILURES FOR <mac, x86, release, cpu> in LayoutTests/platform/qt/test_expectations.txt
> 2011-11-03 10:38:35,836 16718 test_expectations.py:794 ERROR Line:5530 Duplicate or ambiguous expectation. fast/repaint/table-extra-bottom-grow.html
> 
> I removed this entry from test_expectations.txt.

Thanks for fixing, Ossy! It's too bad --lint-test-files only runs on the current platform and there is no way of checking all platforms.