Bug 71417 - [Qt] [WK] Debug build broken
Summary: [Qt] [WK] Debug build broken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-11-02 16:25 PDT by Viatcheslav Ostapenko
Modified: 2011-11-02 23:33 PDT (History)
2 users (show)

See Also:


Attachments
Another debug build fix. (2.32 KB, patch)
2011-11-02 16:31 PDT, Viatcheslav Ostapenko
noam: review+
noam: commit-queue-
Details | Formatted Diff | Diff
Removed stupid tab from Changelog (2.32 KB, patch)
2011-11-02 20:03 PDT, Viatcheslav Ostapenko
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Viatcheslav Ostapenko 2011-11-02 16:25:00 PDT
BundlePage.o ../../../Source/WebKit2/WebProcess/qt/QtBuiltinBundlePage.cpp
../../../Source/WebKit2/WebProcess/qt/QtBuiltinBundlePage.cpp: In constructor ‘WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage(WebKit::QtBuiltinBundle*, WKBundlePageRef)’:
../../../Source/WebKit2/WebProcess/qt/QtBuiltinBundlePage.cpp:70:5: error: missing initializer for member ‘WKBundlePageLoaderClient::didDetectXSSForFrame’ [-Werror=missing-field-initializers]
../../../Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp: In member function ‘void WebKit::QtBuiltinBundle::handleSetNavigatorQtObjectEnabled(WKTypeRef)’:
../../../Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp:134:5: error: ‘WKGetTypeId’ was not declared in this scope
../../../Source/WebKit2/WebProcess/qt/QtBuiltinBundle.cpp:139:5: error: ‘WKBooleanGetTypeID’ was not declared in this scope
Comment 1 Viatcheslav Ostapenko 2011-11-02 16:31:07 PDT
Created attachment 113394 [details]
Another debug build fix.
Comment 2 WebKit Review Bot 2011-11-02 16:34:01 PDT
Attachment 113394 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Noam Rosenthal 2011-11-02 17:28:32 PDT
Comment on attachment 113394 [details]
Another debug build fix.

Please fix style in changelog before committing.
Comment 4 Viatcheslav Ostapenko 2011-11-02 20:03:39 PDT
Created attachment 113424 [details]
Removed stupid tab from Changelog
Comment 5 WebKit Review Bot 2011-11-02 23:33:15 PDT
Comment on attachment 113424 [details]
Removed stupid tab from Changelog

Clearing flags on attachment: 113424

Committed r99141: <http://trac.webkit.org/changeset/99141>
Comment 6 WebKit Review Bot 2011-11-02 23:33:20 PDT
All reviewed patches have been landed.  Closing bug.