Bug 71391 - Make parameters for webaudio biquad filters consistent
Summary: Make parameters for webaudio biquad filters consistent
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Raymond Toy
URL:
Keywords:
Depends on: 71413
Blocks:
  Show dependency tree / graph
 
Reported: 2011-11-02 13:13 PDT by Raymond Toy
Modified: 2013-09-05 08:31 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.76 KB, patch)
2011-11-18 11:20 PST, Raymond Toy 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raymond Toy 2011-11-02 13:13:00 PDT 
The Q parameter for the biquad filters are treated inconsistently.  For all filters except lowpass and highpass filters, Q is the Q parameter, but for the LP and HP filters, Q is the resonance.  

The LP and HP filters should treat the Q parameter as the Q parameter instead of the resonance.
Comment 1 Raymond Toy 2011-11-18 11:20:20 PST 
Created attachment 115839 [details]
Patch
Comment 2 Raymond Toy 2011-11-18 11:22:26 PST 
Make the Q parameter consistent with the Audio EQ Cookbook.

This patch needs to be coordinated with the demos that use lowpass or highpass filters because the meaning of Q has changed.  Q is no longer the resonance in dB, but the actual Q factor.
Comment 3 Raymond Toy 2012-01-25 13:32:55 PST 
Make this depend on bug 71413, which will add biquad tests so we can inherit the tests from there.
Comment 4 Chris Rogers 2013-05-10 17:43:28 PDT 
lowpass and highpass are now in spec as resonance in decibels
Comment 5 Zan Dobersek 2013-09-05 08:31:35 PDT 
Comment on attachment 115839 [details]
Patch

The work on this bug has ceased, removing the r? flag on the patch.