Bug 71390 - Use m_pluginSize instead of m_frameRectInWindowCoordinates.size() in NetscapePlugin
Summary: Use m_pluginSize instead of m_frameRectInWindowCoordinates.size() in Netscape...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-02 13:10 PDT by Anders Carlsson
Modified: 2011-11-02 13:29 PDT (History)
0 users

See Also:


Attachments
Patch (2.21 KB, patch)
2011-11-02 13:10 PDT, Anders Carlsson
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-11-02 13:10:17 PDT
Use m_pluginSize instead of m_frameRectInWindowCoordinates.width in NetscapePlugin
Comment 1 Anders Carlsson 2011-11-02 13:10:35 PDT
Created attachment 113356 [details]
Patch
Comment 2 Adam Roben (:aroben) 2011-11-02 13:21:19 PDT
Comment on attachment 113356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113356&action=review

> Source/WebKit2/ChangeLog:4
> +        Use m_pluginSize instead of m_frameRectInWindowCoordinates.width in NetscapePlugin
> +        https://bugs.webkit.org/show_bug.cgi?id=71390

You also aren't using m_frameRectInWindowCoordinates.height anymore.

I assume m_pluginSize is always equal to m_frameRectInWindowCoordinates.size() in normal cases. It might be worth mentioning that, and whether there are cases where they are not equal.
Comment 3 Anders Carlsson 2011-11-02 13:29:05 PDT
Committed r99092: <http://trac.webkit.org/changeset/99092>