WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
71390
Use m_pluginSize instead of m_frameRectInWindowCoordinates.size() in NetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=71390
Summary
Use m_pluginSize instead of m_frameRectInWindowCoordinates.size() in Netscape...
Anders Carlsson
Reported
2011-11-02 13:10:17 PDT
Use m_pluginSize instead of m_frameRectInWindowCoordinates.width in NetscapePlugin
Attachments
Patch
(2.21 KB, patch)
2011-11-02 13:10 PDT
,
Anders Carlsson
aroben
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2011-11-02 13:10:35 PDT
Created
attachment 113356
[details]
Patch
Adam Roben (:aroben)
Comment 2
2011-11-02 13:21:19 PDT
Comment on
attachment 113356
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=113356&action=review
> Source/WebKit2/ChangeLog:4 > + Use m_pluginSize instead of m_frameRectInWindowCoordinates.width in NetscapePlugin > +
https://bugs.webkit.org/show_bug.cgi?id=71390
You also aren't using m_frameRectInWindowCoordinates.height anymore. I assume m_pluginSize is always equal to m_frameRectInWindowCoordinates.size() in normal cases. It might be worth mentioning that, and whether there are cases where they are not equal.
Anders Carlsson
Comment 3
2011-11-02 13:29:05 PDT
Committed
r99092
: <
http://trac.webkit.org/changeset/99092
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug