Bug 71387 - Plug-in snapshots are blurry in HiDPI
Summary: Plug-in snapshots are blurry in HiDPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-11-02 12:56 PDT by Anders Carlsson
Modified: 2011-11-03 02:13 PDT (History)
10 users (show)

See Also:


Attachments
Patch (3.18 KB, patch)
2011-11-02 13:00 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-11-02 12:56:19 PDT
Plug-in snapshots are blurry in HiDPI
Comment 1 Radar WebKit Bug Importer 2011-11-02 12:59:25 PDT
<rdar://problem/10385393>
Comment 2 Anders Carlsson 2011-11-02 13:00:45 PDT
Created attachment 113355 [details]
Patch
Comment 3 Adam Roben (:aroben) 2011-11-02 13:02:52 PDT
Comment on attachment 113355 [details]
Patch

Can you create a test for this with TestWebKitAPI? You could check the snapshot's dimensions, at a minimum.
Comment 4 Anders Carlsson 2011-11-02 13:04:44 PDT
(In reply to comment #3)
> (From update of attachment 113355 [details])
> Can you create a test for this with TestWebKitAPI? You could check the snapshot's dimensions, at a minimum.

Hmm, since the plug-in snapshot is just painted into the regular snapshot it's not really possible to check the dimensions.
Comment 5 Anders Carlsson 2011-11-02 13:06:12 PDT
Committed r99090: <http://trac.webkit.org/changeset/99090>
Comment 6 Csaba Osztrogonác 2011-11-03 00:45:25 PDT
(In reply to comment #5)
> Committed r99090: <http://trac.webkit.org/changeset/99090>

It broke the GTK build.
Comment 7 Csaba Osztrogonác 2011-11-03 00:50:08 PDT
(In reply to comment #5)
> Committed r99090: <http://trac.webkit.org/changeset/99090>

And the Qt-WK2 build too. (but it isn't a core builder, so you can't notice it)
Comment 8 Simon Hausmann 2011-11-03 02:12:00 PDT
(In reply to comment #7)
> (In reply to comment #5)
> > Committed r99090: <http://trac.webkit.org/changeset/99090>
> 
> And the Qt-WK2 build too. (but it isn't a core builder, so you can't notice it)

Qt builds are fixed in http://trac.webkit.org/changeset/99151.

The remaining Gtk build breakage is due to the dragSession changes.

Closing this bug again, it's definitely fixed :)
Comment 9 Simon Hausmann 2011-11-03 02:13:09 PDT
And http://trac.webkit.org/changeset/99149 fixed the remaining Gtk issues :)