Bug 71384 - Infinite recursion in RenderSVGResourceContainer::markAllClientsForInvalidation
Summary: Infinite recursion in RenderSVGResourceContainer::markAllClientsForInvalidation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
: 69286 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-11-02 12:22 PDT by Levi Weintraub
Modified: 2011-11-10 13:20 PST (History)
4 users (show)

See Also:


Attachments
Test case (380 bytes, image/svg+xml)
2011-11-02 12:22 PDT, Levi Weintraub
no flags Details
Patch (20.02 KB, patch)
2011-11-02 13:46 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-11-02 12:22:31 PDT
Created attachment 113349 [details]
Test case

When there are multiple SVG resources with identical ids that reference one another, you can trigger an infinite recursion in markAllClientsForInvalidation.
Comment 1 Levi Weintraub 2011-11-02 12:23:50 PDT
A very simple guard on RenderSVGResourceContainer fixes this... Will upload soon.

Also tracked here: http://code.google.com/p/chromium/issues/detail?id=99209
Comment 2 Levi Weintraub 2011-11-02 13:46:35 PDT
Created attachment 113370 [details]
Patch
Comment 3 Eric Seidel (no email) 2011-11-02 14:47:44 PDT
Comment on attachment 113370 [details]
Patch

Is this a regression? or have we had thsi bug for a long time?
Comment 4 Levi Weintraub 2011-11-02 14:59:26 PDT
I'm not sure, but I don't believe it to be a recent regression.
Comment 5 Levi Weintraub 2011-11-02 15:06:34 PDT
Comment on attachment 113370 [details]
Patch

Thanks Darin!
Comment 6 WebKit Review Bot 2011-11-02 15:35:33 PDT
Comment on attachment 113370 [details]
Patch

Clearing flags on attachment: 113370

Committed r99109: <http://trac.webkit.org/changeset/99109>
Comment 7 WebKit Review Bot 2011-11-02 15:35:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Tim Horton 2011-11-10 13:20:55 PST
*** Bug 69286 has been marked as a duplicate of this bug. ***