Bug 71372 – Web Inspector: clear fixme in generator script

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Peter Rybin]

Clean fixme in Source/WebCore/inspector/CodeGeneratorInspector.py

[Peter Rybin]

Created attachment 113322 [details]
Patch

[Ilya Tikhonovsky]

looks good to me

[Yury Semikhatsky]

Comment on attachment 113322 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113322&action=review

> Source/WebCore/inspector/CodeGeneratorInspector.py:109
> +        field_name_res = domain_name.lower() + "Agent"

This will generate m_domstorageAgent instead of m_domStorageAgent as per coding style guidelines.

[Peter Rybin]

Do you mean we have standards for generated code that high?

(In reply to comment #3)
> (From update of attachment 113322 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=113322&action=review
> 
> > Source/WebCore/inspector/CodeGeneratorInspector.py:109
> > +        field_name_res = domain_name.lower() + "Agent"
> 
> This will generate m_domstorageAgent instead of m_domStorageAgent as per coding style guidelines.

[Pavel Feldman]

Comment on attachment 113322 [details]
Patch

As per yury's comment.

[Peter Rybin]

Created attachment 115448 [details]
Patch

[Ilya Tikhonovsky]

Comment on attachment 115448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115448&action=review

could you please also fix the indentation for InspectorBackendDispatcher.cpp
the strings:
if (!protocolErrors->length())
    m_anAgent->aCommand(blablabla)
sendResponse(callId, result, blablabla

        static CallHandler handlers[] = {
        &InspectorBackendDispatcher::Page_enable,

and extract String::format("Some arguments of method '%s' can't be processed", "blablabla")
as an inline function.

> Source/WebCore/inspector/CodeGeneratorInspector.py:106
> +    def lower_camel_case_to_upper(str):
> +        if len(str) > 0 and str[0].islower():
> +            str = str[0].upper() + str[1:]
> +        return str

unused. remove it.

> Source/WebCore/inspector/CodeGeneratorInspector.py:126
> +    def camel_case_to_capitilized_with_underscores(str):

capitalized. unused - remove it.

[Peter Rybin]

Ilya,
thank you for review.

> could you please also fix the indentation for InspectorBackendDispatcher.cpp
> the strings:
Done

> and extract String::format("Some arguments of method '%s' can't be processed", "blablabla")
> as an inline function.
I don't think this is really related. Let's handle it separately. By the way, I don't like its string formatting before the error actually happend anyway. On each message you allocate string buffer, build a string and never use it (until an actual error).

> > Source/WebCore/inspector/CodeGeneratorInspector.py:106
> unused. remove it.
Done

> > Source/WebCore/inspector/CodeGeneratorInspector.py:126
> capitalized. unused - remove it.
Done

[Peter Rybin]

Created attachment 115574 [details]
Patch

[Ilya Tikhonovsky]

Comment on attachment 115574 [details]
Patch

lgtm

[Ilya Tikhonovsky]

Comment on attachment 115574 [details]
Patch

Clearing flags on attachment: 115574

Committed r100723: <http://trac.webkit.org/changeset/100723>

[Ilya Tikhonovsky]

All reviewed patches have been landed.  Closing bug.