CSSStyleRule: Devirtualize selectorText()
Created attachment 113314 [details] Purposeful patch
Comment on attachment 113314 [details] Purposeful patch View in context: https://bugs.webkit.org/attachment.cgi?id=113314&action=review > Source/WebCore/css/CSSStyleRule.cpp:50 > + return static_cast<CSSPageRule*>(this)->selectorText(); should be <const CSSPageRule*>
Comment on attachment 113314 [details] Purposeful patch Attachment 113314 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10190295
Comment on attachment 113314 [details] Purposeful patch View in context: https://bugs.webkit.org/attachment.cgi?id=113314&action=review r=me > Source/WebCore/css/CSSStyleRule.cpp:50 > String CSSStyleRule::selectorText() const > { > + if (isPageRule()) > + return static_cast<CSSPageRule*>(this)->selectorText(); It would be less confusing if the subclass function had a different name (pageSelectorText() perhaps?).
Comment on attachment 113314 [details] Purposeful patch Attachment 113314 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10148256
Created attachment 113317 [details] Patch for laundry
Comment on attachment 113317 [details] Patch for laundry Clearing flags on attachment: 113317 Committed r99063: <http://trac.webkit.org/changeset/99063>
All reviewed patches have been landed. Closing bug.