Bug 71364 - CSSStyleRule: Devirtualize selectorText()
Summary: CSSStyleRule: Devirtualize selectorText()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks: 34984
  Show dependency treegraph
 
Reported: 2011-11-02 07:17 PDT by Andreas Kling
Modified: 2012-06-08 12:32 PDT (History)
3 users (show)

See Also:


Attachments
Purposeful patch (2.29 KB, patch)
2011-11-02 07:18 PDT, Andreas Kling
koivisto: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch for laundry (2.80 KB, patch)
2011-11-02 07:41 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-11-02 07:17:06 PDT
CSSStyleRule: Devirtualize selectorText()
Comment 1 Andreas Kling 2011-11-02 07:18:30 PDT
Created attachment 113314 [details]
Purposeful patch
Comment 2 Andreas Kling 2011-11-02 07:19:54 PDT
Comment on attachment 113314 [details]
Purposeful patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113314&action=review

> Source/WebCore/css/CSSStyleRule.cpp:50
> +        return static_cast<CSSPageRule*>(this)->selectorText();

should be <const CSSPageRule*>
Comment 3 WebKit Review Bot 2011-11-02 07:22:47 PDT
Comment on attachment 113314 [details]
Purposeful patch

Attachment 113314 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10190295
Comment 4 Antti Koivisto 2011-11-02 07:23:14 PDT
Comment on attachment 113314 [details]
Purposeful patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113314&action=review

r=me

> Source/WebCore/css/CSSStyleRule.cpp:50
>  String CSSStyleRule::selectorText() const
>  {
> +    if (isPageRule())
> +        return static_cast<CSSPageRule*>(this)->selectorText();

It would be less confusing if the subclass function had a different name (pageSelectorText() perhaps?).
Comment 5 Early Warning System Bot 2011-11-02 07:25:28 PDT
Comment on attachment 113314 [details]
Purposeful patch

Attachment 113314 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10148256
Comment 6 Andreas Kling 2011-11-02 07:41:35 PDT
Created attachment 113317 [details]
Patch for laundry
Comment 7 WebKit Review Bot 2011-11-02 08:45:20 PDT
Comment on attachment 113317 [details]
Patch for laundry

Clearing flags on attachment: 113317

Committed r99063: <http://trac.webkit.org/changeset/99063>
Comment 8 WebKit Review Bot 2011-11-02 08:45:25 PDT
All reviewed patches have been landed.  Closing bug.