RESOLVED FIXED 71359
[GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian) 
https://bugs.webkit.org/show_bug.cgi?id=71359
Summary [GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
Philippe Normand
Reported 2011-11-02 05:54:59 PDT
The fonts-liberation package (previously ttf-liberation) installs the fonts to /usr/share/fonts/truetype/liberation We already added a case for Fedora font paths one year ago. For each font filename there were 2 possible paths. Adding a new search path involves adding a new dimension in the fontPaths variable in initializeFonts(). This is rather painful, I'd propose to have two separate arrays, one for the directories and one for the font filenames we need to register in fontconfig. While this involves a speed penalization I think it's easier to maintain.
Attachments
proposed patch (7.03 KB, patch)
2011-11-02 06:02 PDT, Philippe Normand 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2011-11-02 06:02:03 PDT
Created attachment 113307 [details] proposed patch
Philippe Normand
Comment 2 2011-11-02 06:05:07 PDT
If this approach is not liked I can just do the copy/paste and add a 3rd(!) dimension to that (nasty) array ;)
Martin Robinson
Comment 3 2011-11-02 09:49:36 PDT
Comment on attachment 113307 [details] proposed patch Okay. Do you mind making a similar fix in ActivateFontsGtk.cpp. I hope to get away from this soon!
Philippe Normand
Comment 4 2011-11-02 10:00:37 PDT
(In reply to comment #3) > (From update of attachment 113307 [details]) > Okay. Do you mind making a similar fix in ActivateFontsGtk.cpp. I hope to get away from this soon! Ok, will file a new patch for this, most likely tomorrow. Thanks for the review :)
Philippe Normand
Comment 5 2011-11-03 00:38:31 PDT
Committed r99147: <http://trac.webkit.org/changeset/99147>
Note You need to log in before you can comment on or make changes to this bug.