Bug 71339 - JS Test Harness: Remove more link tags
Summary: JS Test Harness: Remove more link tags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on:
Blocks: 70944
  Show dependency treegraph
 
Reported: 2011-11-01 17:16 PDT by Erik Arvidsson
Modified: 2011-11-03 10:54 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.53 MB, patch)
2011-11-01 17:36 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Patch for landing (1.66 MB, patch)
2011-11-02 13:20 PDT, Erik Arvidsson
no flags Details | Formatted Diff | Diff
Patch for landing (1.66 MB, patch)
2011-11-02 13:28 PDT, Erik Arvidsson
ojan: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Arvidsson 2011-11-01 17:16:11 PDT
JS Test Harness: Remove more link tags
Comment 1 Erik Arvidsson 2011-11-01 17:36:04 PDT
Created attachment 113265 [details]
Patch
Comment 2 Ojan Vafai 2011-11-01 17:59:37 PDT
Comment on attachment 113265 [details]
Patch

Ddeasdasdfasdf
Comment 3 WebKit Review Bot 2011-11-01 18:28:30 PDT
Comment on attachment 113265 [details]
Patch

Attachment 113265 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10190117

New failing tests:
storage/indexeddb/version-change-abort.html
storage/indexeddb/exception-in-event-aborts.html
Comment 4 Alexey Proskuryakov 2011-11-01 21:30:11 PDT
Still no make-new-script-test changes?..
Comment 5 Erik Arvidsson 2011-11-01 21:52:05 PDT
(In reply to comment #4)
> Still no make-new-script-test changes?..

It was updated last week.
Comment 6 Erik Arvidsson 2011-11-02 11:02:09 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > Still no make-new-script-test changes?..
> 
> It was updated last week.

My bad, I thought I did that when I updated it last week. I'll include it in the new patch.
Comment 7 Erik Arvidsson 2011-11-02 13:20:37 PDT
Created attachment 113360 [details]
Patch for landing
Comment 8 Erik Arvidsson 2011-11-02 13:24:59 PDT
Comment on attachment 113360 [details]
Patch for landing

ChangeLog failure
Comment 9 Erik Arvidsson 2011-11-02 13:28:43 PDT
Created attachment 113363 [details]
Patch for landing
Comment 10 WebKit Review Bot 2011-11-02 13:33:38 PDT
Comment on attachment 113363 [details]
Patch for landing

Rejecting attachment 113363 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

NOBODY (OOPS!) found in /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/10256369
Comment 11 WebKit Review Bot 2011-11-02 15:08:45 PDT
Comment on attachment 113363 [details]
Patch for landing

Rejecting attachment 113363 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/10259364
Comment 12 Ojan Vafai 2011-11-02 16:35:14 PDT
You should just land this manually.
Comment 13 Erik Arvidsson 2011-11-03 10:54:54 PDT
Committed r99220: <http://trac.webkit.org/changeset/99220>